all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Robert Weiner <rsw@gnu.org>
Cc: 14120@debbugs.gnu.org
Subject: bug#14120: [Robert Weiner] Emacs history selection non-string arguments causing failures for a long time
Date: Sun, 16 Feb 2020 20:52:32 -0500	[thread overview]
Message-ID: <jwvk14m6l9z.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <jwv7e0mjlrv.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Sun, 16 Feb 2020 15:55:12 -0500")

> This bug #14120 in subr.el is still occurring in Emacs 27.0.50 because
> leading entries like (require . info) rather than strings are being
> injected into the history.  Since this has affected people for quite a
> while, I hope you or someone else can add this one line change to the Emacs
> 27 branch and resolve it.

The original #14120 report was linked to the use of CANNOT_DUMP which is
not used any more, AFAICT, so we haven't really investigated this bug.

Concretely, I don't know how/where this shows up.  Do you have some
recipe (and/or backtrace)?

> !  ;; https://debbugs.gnu.org/cgi/bugreport.cgi?bug=14120
> !  ;; Avoid this bug still occuring in Emacs 27.0.50 by checking
> !  ;; if load-elt is a string or not.
> !  (or (not (stringp (car load-elt)))
>        (not (string-match file-regexp (car load-elt)))))

The docstring of `load-history` says that (car load-elt) should never be
anything else than a string or nil.  So the right fix is likely
elsewhere.


        Stefan






  reply	other threads:[~2020-02-17  1:52 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-01 22:47 bug#14120: invalid load-history in emacsen that CANNOT_DUMP BT Templeton
2013-04-03 18:29 ` Stefan Monnier
2019-09-06  0:09   ` Glenn Morris
2020-02-17 13:34   ` Andrés Ramírez
2020-02-17 15:09     ` Stefan Monnier
2020-02-17 17:14       ` andrés ramírez
2020-02-17 17:46         ` Stefan Monnier
2020-02-18  1:01           ` andrés ramírez
2020-02-18  1:34             ` andrés ramírez
2020-02-18 13:40               ` Stefan Monnier
2020-02-18 13:50                 ` andrés ramírez
2020-02-16 20:55 ` bug#14120: [Robert Weiner] Emacs history selection non-string arguments causing failures for a long time Stefan Monnier
2020-02-17  1:52   ` Stefan Monnier [this message]
2020-02-17  2:22     ` Robert Weiner
2020-02-17  3:18     ` Glenn Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvk14m6l9z.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=14120@debbugs.gnu.org \
    --cc=rsw@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.