From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master c59e878: Inhibit modification hooks when saving eieio-persistent's Date: Fri, 01 May 2020 18:03:05 -0400 Message-ID: References: <20200501192115.23847.67499@vcs0.savannah.gnu.org> <20200501192116.A55EE20B5B@vcs0.savannah.gnu.org> <87368jba7f.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="108172"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Michael Heerdegen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat May 02 00:05:43 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jUdmw-000S06-Ab for ged-emacs-devel@m.gmane-mx.org; Sat, 02 May 2020 00:05:42 +0200 Original-Received: from localhost ([::1]:33502 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jUdmv-0005lz-8o for ged-emacs-devel@m.gmane-mx.org; Fri, 01 May 2020 18:05:41 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58316) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jUdkt-0004i5-2h for emacs-devel@gnu.org; Fri, 01 May 2020 18:03:42 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jUdkX-0001oq-BF for emacs-devel@gnu.org; Fri, 01 May 2020 18:03:33 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:27270) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jUdkW-0001nw-Qo for emacs-devel@gnu.org; Fri, 01 May 2020 18:03:12 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 907CE100F54; Fri, 1 May 2020 18:03:08 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id F09FD100F44; Fri, 1 May 2020 18:03:06 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1588370586; bh=425dWgqAPz4hNwJlpIIpkgz6n14ZkmGD+yCPzpoO5iw=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Fa3yYDBbAv4Qsen0Db0FeDFFyeBqVQdph62Uz4cWi9apyhfGoro/ABsHBTlXaiuTD Qu8PLaOASkQ8rY6xvBdgKSacnbtayIQbUJVrAqf1CQxboLwzcEFjah4n4S8d+mHMc/ Ps2vbmf7TnuaTDQKOKbrxV1b3l1SnzQVegnJ/XkbBWGJR4UHwQou5FB/OegxGxlHmk T9Qx3U14FYFWeiuU43BNbhZeqXzmOd1EH7aEM6/jfz5t/VTXhVrxNvSXU08DdQF7/l CtV8iROJ3wXDiIg17DQ1ij1e7yCx8MhV5b/Skk288uS0FtKqK0FYhTBg862glNEyfi DoQ8okdW827Rw== Original-Received: from alfajor (unknown [216.154.3.202]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id BC3D41205FB; Fri, 1 May 2020 18:03:06 -0400 (EDT) In-Reply-To: <87368jba7f.fsf@web.de> (Michael Heerdegen's message of "Fri, 01 May 2020 23:45:56 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/01 17:01:49 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Received-From: 132.204.25.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:248345 Archived-At: > I thought this would be obvious? The output always goes into a fresh > temp buffer the user never sees, and the goal is to speed things up. It's far from the only code which adds things to a temp buffer, yet we usually don't bind that var around such code because the speed difference is usually not significant. What kind of speed up have you noticed? Have you profiled it to see which change-functions slow us down (maybe we can disable them some other way, such as by using another major mode)? Have you tried to use `combine-change-calls`? Stefan