From: Stefan Monnier <monnier@iro.umontreal.ca>
To: "Štěpán Němec" <stepnem@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: Calling internal-default-process-sentinel from another sentinel?
Date: Wed, 18 Nov 2020 09:44:18 -0500 [thread overview]
Message-ID: <jwvk0uibufh.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87pn4a688z.fsf@gmail.com> ("Štěpán Němec"'s message of "Wed, 18 Nov 2020 15:37:48 +0100")
>>> Such a use case doesn't seem uncommon and simply calling
>>> 'internal-default-process-sentinel' from a custom sentinel would seem a
>>> good solution, but the "internal-" prefix or the fact that such usage is
>>> completely absent from Emacs core and very rare even in 3rd party
>>> code[1] don't inspire confidence.
>>
>> `add-function` is your friend.
>>
>> (add-function :around (process-sentinel proc)
>> (lambda (orig-fun proc state)
>> (if (one particular case)
>> (do the thing)
>> (funcall orig-fun proc state))))
>
> Thanks, I've seen similar examples in the code base, but always advising
> an Elisp sentinel, not 'internal-default-process-sentinel', which is a C
> function, and IIUC also would/might be called from C (e.g. from
> status_notify ?). Or is the actual default sentinel some kind of a
> wrapper?
This is not advising 'internal-default-process-sentinel'. It just
replaces the sentinel by a new function which often delegates to the
previous function, whichever that previous function was and without
affecting that previous function's definition.
> And even for Elisp sentinels, I figured I'd rather avoid advice, as even
> when using a self-removing piece of advice, it still applies to all
> (even unrelated) calls of the same sentinel function occurring until the
> removal. Or am I missing something?
You're confused: this is not an "advice".
Stefan
next prev parent reply other threads:[~2020-11-18 14:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-18 13:28 Calling internal-default-process-sentinel from another sentinel? Štěpán Němec
2020-11-18 14:19 ` Stefan Monnier
2020-11-18 14:37 ` Štěpán Němec
2020-11-18 14:44 ` Stefan Monnier [this message]
2020-11-18 15:12 ` Štěpán Němec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvk0uibufh.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=stepnem@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.