* About appt-update-list local hook
@ 2021-03-14 0:22 Gabriel
2021-03-14 15:45 ` Stefan Monnier
0 siblings, 1 reply; 2+ messages in thread
From: Gabriel @ 2021-03-14 0:22 UTC (permalink / raw)
To: emacs-devel
So I have been playing with Calendar, Diary and Appointments
lately. According to the documentation[1]:
"The appointments list is also updated whenever the diary file (or a file
it includes; see Fancy Diary Display) is saved"
But it was not working using Emacs built from master branch. Then I
discovered that commit '587a97bcb23bc6ea429ab790efa03f2260a9bca8'
changed the hook to be local mode. With this change, the diary-file is
tracked for changes only if 'appt-activate' is called inside a
diary-file buffer, but I call 'appt-activate' inside my init file. I
could not find any bug or thread linked to this commit, and the commit
does not contain any descriptive information. The commentary of appt.el
and the docstring of 'appt-update-list' also indicates that the
diary-file is always tracked for changes, regardless of how/where
'appt-activate' is called.
Is correct this local hook ? If so, should we update the docs ?
[1] https://www.gnu.org/software/emacs/manual/html_node/emacs/Appointments.html
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: About appt-update-list local hook
2021-03-14 0:22 About appt-update-list local hook Gabriel
@ 2021-03-14 15:45 ` Stefan Monnier
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Monnier @ 2021-03-14 15:45 UTC (permalink / raw)
To: Gabriel; +Cc: emacs-devel
> But it was not working using Emacs built from master branch. Then I
> discovered that commit '587a97bcb23bc6ea429ab790efa03f2260a9bca8'
> changed the hook to be local mode. With this change, the diary-file is
Indeed, that was an error. I just reverted it, thanks.
IIRC when I made this change it was because `write-file-contents` was
made local but without the `t` element, so I mistakenly thought it was one of
those hooks that are always local. Now I'll have to figure out why that
hook was "local without the `t`".
Stefan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-14 15:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-14 0:22 About appt-update-list local hook Gabriel
2021-03-14 15:45 ` Stefan Monnier
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.