From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 501e2096d6: Fix some issues with a recent change Date: Mon, 27 Dec 2021 01:14:46 -0500 Message-ID: References: <164051393145.21885.8315099612759503047@vcs2.savannah.gnu.org> <20211226101851.B61E5C04DCC@vcs2.savannah.gnu.org> <83bl13nsav.fsf@gnu.org> <87fsqe3ly7.fsf@yahoo.com> <874k6u3alb.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4235"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Dec 27 07:17:20 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n1jJv-0000rq-Iw for ged-emacs-devel@m.gmane-mx.org; Mon, 27 Dec 2021 07:17:19 +0100 Original-Received: from localhost ([::1]:46696 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n1jJs-0001hW-JG for ged-emacs-devel@m.gmane-mx.org; Mon, 27 Dec 2021 01:17:18 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:45360) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n1jHZ-0000x5-1t for emacs-devel@gnu.org; Mon, 27 Dec 2021 01:14:53 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:42331) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n1jHW-0008Mp-VQ; Mon, 27 Dec 2021 01:14:52 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 44A104402BC; Mon, 27 Dec 2021 01:14:49 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id F01864402A4; Mon, 27 Dec 2021 01:14:47 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1640585687; bh=oU89EueAxDmO4P745TKg5a6lPrPSeUQuwX63uSzBqMk=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=gguVIi5GRigWuL9m5cnM1HGpjRSKoKwqkV3NSAhCWT2S6TJMmHsIcfV6smD+boMBN CvCUmIcgojMCs5wTGubxyvGX6BSP6seNJKUrzczUcMsRmBTyKrVM3qzL7N6jchRWdX jEk7EH84RIN5cLZeyPJKvj8p+i69PLUXh3PYqP75asvXolZjWB1DnPOtQqvwHubXXV mnpwPEXTHbxVO1B/fqM+uA92Sgl5+ruKxr4e6a0lZX+AC4XK/GbEXbRuy1+ILOl/2A 8Joe1CHyQKTSkw4uHHNlWo51yvrwKfeGD0FBf5YLpnxnEMTtDYfvATL3wZyy7TC1hg 3bRM5GAiUbFkg== Original-Received: from ceviche (unknown [216.154.30.173]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id A06B812020D; Mon, 27 Dec 2021 01:14:47 -0500 (EST) In-Reply-To: <874k6u3alb.fsf@yahoo.com> (Po Lu's message of "Mon, 27 Dec 2021 13:01:20 +0800") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:283399 Archived-At: >> The main change was to `face-remap.el` so having `face-remap.el` in the >> first line would have been very helpful to me. Another option would have >> been to include `text-scale-pinch` in the first line, that would have >> worked great for me as well. > >> The other changes were largely secondary and related, so it's OK if they >> don't get any mention in the first line. > > None of that change is "secondary": they all fixed issues Eli pointed > out in an earlier discussion. Maybe we can't agree on it being "secondary" but all those changes are related to pinch or to code that is itself related to that. So including those words would give some hint as to what it is you've changed, whereas the first line you've used gave no indication whatsoever about which part of the codebase was modified. Basically, think of the reader who'd like to quickly know "could this change affect `doctor.el`?" Stefan