From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 1b71c995da: Avoid binding mouse-1 in xref when mouse-1 doesn't follow links Date: Fri, 29 Apr 2022 13:17:45 -0400 Message-ID: References: <165123369667.6415.4605821518748112960@vcs2.savannah.gnu.org> <20220429120137.0F053C06322@vcs2.savannah.gnu.org> <87fslwdo88.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22090"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Apr 29 19:18:45 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nkUGT-0005W4-1x for ged-emacs-devel@m.gmane-mx.org; Fri, 29 Apr 2022 19:18:45 +0200 Original-Received: from localhost ([::1]:44904 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nkUGR-0008E4-Vf for ged-emacs-devel@m.gmane-mx.org; Fri, 29 Apr 2022 13:18:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40422) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nkUFj-0007X2-45 for emacs-devel@gnu.org; Fri, 29 Apr 2022 13:17:59 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:59597) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nkUFf-0007X3-SW for emacs-devel@gnu.org; Fri, 29 Apr 2022 13:17:57 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id C494480677; Fri, 29 Apr 2022 13:17:53 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 6DD81805E4; Fri, 29 Apr 2022 13:17:52 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1651252672; bh=5wdnrY6/rvfii/0UXLq2m7hnkH81EAEws5tTAhrbAyo=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=nvTwwTdkDxFmNLpiny/Zw2uy4dm6suD421E5Jrf5qJW6DYeYXYbqNkEJOYWvqSmwi I22U08ZLE9rG802HE7PwCY5VD+BsDLxlwEIglveUdKylHnSqDQu4ZU5ORt7P4nzxxc TIGMAsezrNsrafqEpBY6uat6O3PuUKu3cqrGqxj6HLmXXIvS1mN3z+4zuMfIFLCt3Q qMgittYSyY/giHxsz6fkUM1NYWIBLCm/vl+IUr9Vz/9Xlgja5OzPZs5RzWvD4tRXQj yvBBakQs8kIdWlWYEWKOynz4eDYmJD7bei84Ow5wCbOspSWvsCx2jaFqUOMhizMjmd AM4SMDfjdGe6w== Original-Received: from alfajor (unknown [45.72.221.51]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 432D6120312; Fri, 29 Apr 2022 13:17:52 -0400 (EDT) In-Reply-To: <87fslwdo88.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 29 Apr 2022 15:16:07 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:289012 Archived-At: Lars Ingebrigtsen [2022-04-29 15:16:07] wrote: > Stefan Monnier writes: >> Hmm... this won't adjust if `mouse-1-click-follows-link` is changed >> later on. Why do we need this `mouse-1` binding? > Dmitry seems to like the two different actions (which only differ in > whether the other buffer is selected or not). I'd be fine with removing > the mouse-1 binding. I think the benefit of using the "standard" behavior (i.e. only have a mouse-2 binding and rely on `mouse-1-click-follows-link` to make it available on `mouse-1`) outweighs the benefit of choosing between those two slightly different behaviors by opting for one binding or the other. Stefan