From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#56347: Optimize/simplify STRING_SET_MULTIBYTE Date: Sat, 02 Jul 2022 14:37:18 -0400 Message-ID: References: <83pmioca3h.fsf@gnu.org> <83letbbhzx.fsf@gnu.org> <83bku7bc3c.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21860"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 56347@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jul 02 20:38:10 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o7i0P-0005Vs-Dk for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 02 Jul 2022 20:38:09 +0200 Original-Received: from localhost ([::1]:58252 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o7i0O-0000oY-Bz for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 02 Jul 2022 14:38:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57922) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o7i0I-0000o8-5v for bug-gnu-emacs@gnu.org; Sat, 02 Jul 2022 14:38:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48955) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o7i0H-0002vc-Tt for bug-gnu-emacs@gnu.org; Sat, 02 Jul 2022 14:38:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o7i0H-0000r3-NZ for bug-gnu-emacs@gnu.org; Sat, 02 Jul 2022 14:38:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 Jul 2022 18:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56347 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 56347-submit@debbugs.gnu.org id=B56347.16567870493244 (code B ref 56347); Sat, 02 Jul 2022 18:38:01 +0000 Original-Received: (at 56347) by debbugs.gnu.org; 2 Jul 2022 18:37:29 +0000 Original-Received: from localhost ([127.0.0.1]:42852 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o7hzl-0000qF-5D for submit@debbugs.gnu.org; Sat, 02 Jul 2022 14:37:29 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:58644) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o7hzi-0000q3-Ua for 56347@debbugs.gnu.org; Sat, 02 Jul 2022 14:37:27 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 723B1100164; Sat, 2 Jul 2022 14:37:21 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 0E6A8100121; Sat, 2 Jul 2022 14:37:20 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1656787040; bh=0fQUsY4wROiBu7XEvJqhZQPNtwHuzsC1G/RveC1557I=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=LQZUS7vX6YUtbLBQ10XI9QflMUjDM/ifEJUKILu5vb3hd+rBfbsbOQlmEYTcM4Klx zH4QqnlSp1g+JDBmsyznURo/bwz8f9NMpMdcmxmZx4oU7haY0PCcXAeteKJChzeNhw ISRU+6k8IZIdNE6vDTnfTn1wffheSz7HgQA7QdQ6tZZ1ByaJOHercDeYj12fHOufKR F/CwLciJVbL2lY62DKs3z85IzAZLrHWQAYhhFTV1b9k3LaDJIKmi+DykK78jvRFsU/ JynSe2ZewuGyqfkFLOyARvQLM0kUcdAhk11v0sbOOWPhfPRgCBtFdUfI4ZLvEERRp6 DliZ+PjWNXSsA== Original-Received: from alfajor (unknown [45.72.196.165]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id D767712043F; Sat, 2 Jul 2022 14:37:19 -0400 (EDT) In-Reply-To: <83bku7bc3c.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 02 Jul 2022 21:31:35 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:235952 Archived-At: >> Yes. In my book, STRING_SET_*IBYTE should basically not exist: a string >> is created as unibyte or multibyte and never changes after that. > > That's require a much larger change, I think. It is not enough just > to add an assertion in one place, because that'd just cause > maintenance headaches for no real gain. `grep STRING_SET_MULTIBYTE` suggests it's not nearly as hard you think. The only other use is in `aset`. >> And indeed because we only have a single copy of the two possible empty >> strings, they can't be changed between unibyte<->multibyte > I can create an empty string without those singletons any time. My experience is that it takes a fair bit of work to do so. Stefan