From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Using Emacs in fbterm. Date: Tue, 30 Aug 2022 14:26:43 -0400 Message-ID: References: <83czcjvtt2.fsf@gnu.org> <874jxu4zeg.fsf@igel.home> <87v8qa3k0b.fsf@igel.home> <83r10yufto.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7454"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Eli Zaretskii , acm@muc.de, schwab@linux-m68k.org, emacs-devel@gnu.org To: Gregory Heytings Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Aug 30 20:28:14 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oT5yA-0001gN-8h for ged-emacs-devel@m.gmane-mx.org; Tue, 30 Aug 2022 20:28:14 +0200 Original-Received: from localhost ([::1]:51648 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oT5y8-0001Oy-LB for ged-emacs-devel@m.gmane-mx.org; Tue, 30 Aug 2022 14:28:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:32944) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oT5wq-0000hU-7J for emacs-devel@gnu.org; Tue, 30 Aug 2022 14:26:53 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:30397) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oT5wn-0002Rh-G4; Tue, 30 Aug 2022 14:26:51 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 1C7A244270E; Tue, 30 Aug 2022 14:26:47 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 3C9A0442708; Tue, 30 Aug 2022 14:26:45 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1661884005; bh=+p5197I2yghDX8+wDqx02dEJ9jB0Fbe2Mn/tzkco/ME=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=LrQUyd5MjudFglrUZnIbrc5mgdbo3lSiU1e1hCTIr15EQfC4PyTI5isHEA/7F+9vS SyluBVoLuwffmlrtnZ7/HxVtY7RgIaXEhZH40yZAgabXRFENlBLeYxuPeBy8+UcZgd NRqGXeG62ZiWtP0pZTtjhOhkVCsjdyoZBdaMjz5/AUz6wS7P4ClPNN8IuWqUAojDHg hYpOagXkcaVH9OD707Qxs3xZzaBp5IVVJh6sgO3m1Q1qd9ld2yKyjSbo+FaE0aO40A eSk7ZLJ7sPy4WkRRJ8o5KzJ8RuTcRrQ8xT6TfEasB8MYZnlAHrvZ2YuXmocV6NCz4r wT0jvHXvzmlQQ== Original-Received: from alfajor (unknown [45.44.229.252]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id DA87112076C; Tue, 30 Aug 2022 14:26:44 -0400 (EDT) In-Reply-To: (Gregory Heytings's message of "Tue, 30 Aug 2022 15:37:56 +0000") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:294379 Archived-At: >>> +;;; fbterm.el -*- lexical-binding:t -*- >>> +(require 'term/xterm) >> This lacks the usual license blurb, of course > Short files in lisp/term/ do not have that license blurb, I thought it was > on purpose? Hmm..... interesting. I don't know what should be done in this respect. But the important thing is to explain/document the why of the code so that 10 years from now someone will know how to maintain it. >>> + (ignore-errors (when gpm-mouse-mode (require 't-mouse) (gpm-mouse-enable)))) >> Hmm... this seems to point to a problem/shortcoming in `t-mouse.el` which >> should arguably do that automatically, no? > I confess I blindly copied that line from linux.el, thinking it was > probably useful for something. It should probably be removed from there as well. If it causes a regression that should be fixed in `t-mouse.el` or at the very least come with a clear description of the problem it fixes. > After some testing it doesn't seem to make a difference, so I'll just > remove it. Great, thanks, Stefan