From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: feature/improved-locked-narrowing 9dee6df39c: Reworked locked narrowing. Date: Fri, 30 Dec 2022 11:22:12 -0500 Message-ID: References: <166939872890.18950.12581667269687468681@vcs2.savannah.gnu.org> <20221125175209.51166C004B6@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33615"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Gregory Heytings To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Dec 30 17:22:46 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pBI9e-0008XR-8L for ged-emacs-devel@m.gmane-mx.org; Fri, 30 Dec 2022 17:22:46 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pBI9F-0006Zn-Fv; Fri, 30 Dec 2022 11:22:21 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pBI9D-0006ZF-It for emacs-devel@gnu.org; Fri, 30 Dec 2022 11:22:19 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pBI9B-0001kc-SV for emacs-devel@gnu.org; Fri, 30 Dec 2022 11:22:19 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 6CC9D80608; Fri, 30 Dec 2022 11:22:15 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id DCD0D80496; Fri, 30 Dec 2022 11:22:13 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1672417333; bh=QsQioh+00z/eWmGBCxd+ZvXvDer376Ftup6+iiW16g4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=YCB8Wp+8sjMpxyLkFhO6ECD30Ck+II9myPM1CAN67RigA4qV1mFeKy6ByN3UJB3TJ 6KZq/9B5EK9m0S2DnobuMu6+bKdcrbXgmdeA1zqLGEasJJZa3cNZVutH34RT82i6yk b9FfT8rjGu7S0+9YaaITLmwB3mZQVZJuWQx7kKkyyv9v/MMf56UyxCu90kqpUpZpUl olLD3qmKxa9HEY1UnE2cWvgGxYI0suwwczFByqX2NggiJ48mxzAFgXTbMReWUklwab yszUDT4MgSai2d2cpBHd8mlG7+KNxxrdezwQQSrtnJ1B1IQqWrZZiWkuX1P6JybPqu sQvW5S+nGLdTQ== Original-Received: from alfajor (unknown [45.44.229.252]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id C0AA01200A5; Fri, 30 Dec 2022 11:22:13 -0500 (EST) In-Reply-To: <20221125175209.51166C004B6@vcs2.savannah.gnu.org> (Gregory Heytings's message of "Fri, 25 Nov 2022 12:52:09 -0500 (EST)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:302126 Archived-At: > Reworked locked narrowing. > > * src/editfns.c: (narrowing_locks): New alist to hold the narrowing > locks and their buffers. > (narrowing_lock_get_bound, narrowing_lock_peek_tag) > (narrowing_lock_push, narrowing_lock_pop): New functions to access > and update 'narrowing_locks'. > (reset_outermost_narrowings, unwind_reset_outermost_narrowing): > Functions moved from src/xdisp.c, and rewritten with the above > functions. > (Fwiden): Use the above functions. Update docstring. > (Fnarrow_to_region, Fnarrowing_lock, Fnarrowing_unlock): Use the above > functions. > (syms_of_editfns): Remove the 'narrowing-locks' variable. > > * src/lisp.h: Make 'reset_outermost_narrowings' externally visible. > > * src/xdisp.c (reset_outermost_narrowings) > unwind_reset_outermost_narrowing): Functions moved to src/editfns.c. > > * lisp/subr.el (with-locked-narrowing): Improved macro, with a helper > function. [ Sorry for coming late. ] This commit (which is now on emacs-29 branch) still has some problems: - I don't see any mention of those new features in etc/NEWS. - I can't think of a case where a piece of code could/should make use of `narrowing-unlock`. - In `nlinum--line-number-at-pos`, I want to circumvent the narrowing lock due to long lines (since its performance is only affected by buffer size but not by line length), but I can't see how to do that. The only primitive I see which would let me get out of the locked narrowing is `narrowing-unlock` but: - I don't know which tag(s) to use. - I don't want to remove the lock, I only want to circumvent it temporarily, and I can't see how to re-install a lock after removing it (`narrowing-lock` doesn't fit the bill because I don't know the bounds of the lock and because that would not preserve the stacking order of locks). -- Stefan