From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#64391: buffer narrowing slowdown regression in emacs 29 Date: Sun, 09 Jul 2023 14:52:52 -0400 Message-ID: References: <87r0psb51z.fsf@ust.hk> <5995c9ed6a0b39c3070c@heytings.org> <83a5wak1tr.fsf@gnu.org> <26cee506f708f3c6cfe1@heytings.org> <26cee506f70bbc9de58b@heytings.org> <83h6qghpdc.fsf@gnu.org> <26cee506f77e9c87e325@heytings.org> <06A8380F-08A6-464E-9946-02F8498031EC@gmail.com> <239e2a5aa11924a2f1d3@heytings.org> <239e2a5aa14d33c1b087@heytings.org> <83jzv9bp0a.fsf@gnu.org> <17bc5861309c808fe41c@heytings.org> <831qhhbh60.fsf@gnu.org> <17bc5861306adf83809a@heytings.org> <837cr99gz1.fsf@gnu.org> <17bc58613018aff5cea9@heytings.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24453"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: acohen@ust.hk, 64391@debbugs.gnu.org, eliz@gnu.org, mattias.engdegard@gmail.com To: Gregory Heytings Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 09 20:54:32 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qIZYG-0006D4-FS for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 09 Jul 2023 20:54:32 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qIZXt-0002rH-1E; Sun, 09 Jul 2023 14:54:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qIZXq-0002qr-78 for bug-gnu-emacs@gnu.org; Sun, 09 Jul 2023 14:54:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qIZXm-0003aJ-9Z for bug-gnu-emacs@gnu.org; Sun, 09 Jul 2023 14:54:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qIZXl-00086Y-NK; Sun, 09 Jul 2023 14:54:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Sun, 09 Jul 2023 18:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64391 X-GNU-PR-Package: emacs,gnus X-Debbugs-Original-Cc: acohen@ust.hk, 64391@debbugs.gnu.org, Eli Zaretskii , mattias.engdegard@gmail.com, bugs@gnus.org Original-Received: via spool by 64391-submit@debbugs.gnu.org id=B64391.168892879431096 (code B ref 64391); Sun, 09 Jul 2023 18:54:01 +0000 Original-Received: (at 64391) by debbugs.gnu.org; 9 Jul 2023 18:53:14 +0000 Original-Received: from localhost ([127.0.0.1]:47158 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qIZWy-00085S-8Q for submit@debbugs.gnu.org; Sun, 09 Jul 2023 14:53:13 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:47629) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qIZWs-00084t-GY for 64391@debbugs.gnu.org; Sun, 09 Jul 2023 14:53:11 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id F3411440FD2; Sun, 9 Jul 2023 14:53:00 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id C12E14402F0; Sun, 9 Jul 2023 14:52:59 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1688928779; bh=eM9BJFyNaWbSCL7bwmdTtjZudEcyVkV+vcnT5/HphAo=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=V7oxHdbsfUuzIcFtGuhPUIBOrqOcZ0rvutCAxfmWuz8BeKH1U4ENS9M78MANBa4WI +aSbl+gc5f+icgqPm2CoxqThT9UtaNh4JDG6jyJ4R1cG/qmPC9JVO6yslNybpbW26n 4aTnZAy+xc4+Sux9kuvtuIa6cMYP9qxcUDZL0FgK8YPjC2QRSjlL0TbxA/kVbSwKag WLyFuz1LvT1H3wGIuqAjRjbR0pM3mKVQ8xfZoQXFhr/ao/4Lfoqf9UgOdd17F23F08 dXfw4eC/Syqayu6bby+DfYf+FzUxRHWgf3hpDWE/QM7QR1sP2JZhm1TKicsWXL1FeJ vX6pg6k8CSHKA== Original-Received: from pastel (unknown [24.140.234.50]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 874ED120247; Sun, 9 Jul 2023 14:52:59 -0400 (EDT) In-Reply-To: <17bc58613018aff5cea9@heytings.org> (Gregory Heytings's message of "Sun, 09 Jul 2023 18:03:02 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:264852 Archived-At: > \(fn START END [:label LABEL] BODY)" > (declare (indent 2) (debug t)) > - (if (eq (car rest) :label) > + (if (and (eq (car rest) :label) > + (symbolp (cadr rest))) > `(internal--with-restriction ,start ,end (lambda () ,@(cddr rest)) > ,(cadr rest)) > `(internal--with-restriction ,start ,end (lambda () ,@rest)))) Doesn't look right: (cadr rest) should be an *expression* that evaluates to a symbol, so in general it won't itself be a symbol. >>> -When the optional argument @var{label}, a symbol, is present, the >>> -narrowing is @dfn{labeled}. A labeled narrowing differs from a >>> -non-labeled one in several ways: >>> +When the optional argument @var{label}, which is evaluated to get the >>> +label to use and must not be @code{nil}, >> What "must not be nil": the label or the result of its evaluation? > The result of the evaluation of the label argument. I don't know how to > make this clearer. Maybe: When the optional argument @var{label}, which should evaluate to a non-nil value, -- Stefan