From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Gregory Heytings <gregory@heytings.org>
Cc: acohen@ust.hk, 64391@debbugs.gnu.org, eliz@gnu.org,
mattias.engdegard@gmail.com
Subject: bug#64391: buffer narrowing slowdown regression in emacs 29
Date: Sun, 09 Jul 2023 14:52:52 -0400 [thread overview]
Message-ID: <jwvjzv8syv5.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <17bc58613018aff5cea9@heytings.org> (Gregory Heytings's message of "Sun, 09 Jul 2023 18:03:02 +0000")
> \(fn START END [:label LABEL] BODY)"
> (declare (indent 2) (debug t))
> - (if (eq (car rest) :label)
> + (if (and (eq (car rest) :label)
> + (symbolp (cadr rest)))
> `(internal--with-restriction ,start ,end (lambda () ,@(cddr rest))
> ,(cadr rest))
> `(internal--with-restriction ,start ,end (lambda () ,@rest))))
Doesn't look right: (cadr rest) should be an *expression* that evaluates
to a symbol, so in general it won't itself be a symbol.
>>> -When the optional argument @var{label}, a symbol, is present, the
>>> -narrowing is @dfn{labeled}. A labeled narrowing differs from a
>>> -non-labeled one in several ways:
>>> +When the optional argument @var{label}, which is evaluated to get the
>>> +label to use and must not be @code{nil},
>> What "must not be nil": the label or the result of its evaluation?
> The result of the evaluation of the label argument. I don't know how to
> make this clearer.
Maybe:
When the optional argument @var{label}, which should evaluate to
a non-nil value,
-- Stefan
next prev parent reply other threads:[~2023-07-09 18:52 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-01 0:15 bug#64391: 30.0.50; buffer narrowing slowdown regression in emacs 29 Andrew Cohen
2023-07-01 2:45 ` bug#64391: bug 64391 wrong git info Andrew Cohen
2023-07-01 4:59 ` bug#64391: more info Andrew Cohen
2023-07-01 11:37 ` bug#64391: buffer narrowing slowdown regression in emacs 29 Mattias Engdegård
2023-07-01 12:08 ` Eli Zaretskii
2023-07-01 12:52 ` Mattias Engdegård
2023-07-02 7:35 ` Gregory Heytings
2023-07-05 11:57 ` Eli Zaretskii
2023-07-06 14:41 ` Gregory Heytings
2023-07-06 17:33 ` Gregory Heytings
2023-07-06 18:22 ` Eli Zaretskii
2023-07-06 18:45 ` Gregory Heytings
2023-07-07 9:30 ` Mattias Engdegård
2023-07-07 10:00 ` Gregory Heytings
2023-07-07 10:23 ` Eli Zaretskii
2023-07-07 10:31 ` Gregory Heytings
2023-07-07 12:41 ` Eli Zaretskii
2023-07-07 12:46 ` Gregory Heytings
2023-07-07 11:33 ` Mattias Engdegård
2023-07-07 12:42 ` Gregory Heytings
2023-07-07 15:49 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-08 20:58 ` Gregory Heytings
2023-07-08 21:42 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-08 22:21 ` Gregory Heytings
2023-07-08 23:22 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-09 16:03 ` Gregory Heytings
2023-07-09 18:57 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-09 6:03 ` Eli Zaretskii
2023-07-09 8:35 ` Gregory Heytings
2023-07-09 8:52 ` Eli Zaretskii
2023-07-09 16:04 ` Gregory Heytings
2023-07-09 16:39 ` Eli Zaretskii
2023-07-09 18:03 ` Gregory Heytings
2023-07-09 18:52 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-07-09 19:19 ` Gregory Heytings
2023-07-09 19:42 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-09 19:44 ` Gregory Heytings
2023-07-09 19:03 ` Eli Zaretskii
2023-07-09 19:06 ` Eli Zaretskii
2023-07-09 19:29 ` Gregory Heytings
2023-07-07 10:27 ` Eli Zaretskii
2023-07-07 11:27 ` Mattias Engdegård
2023-07-07 12:50 ` Eli Zaretskii
2023-07-07 16:49 ` Mattias Engdegård
2023-07-07 18:22 ` Eli Zaretskii
2023-07-08 8:01 ` Eli Zaretskii
2023-07-08 19:41 ` Gregory Heytings
2023-07-02 9:37 ` Mattias Engdegård
2023-07-01 7:07 ` bug#64391: 30.0.50; " Eli Zaretskii
2023-07-01 7:31 ` Andrew Cohen
2023-07-01 8:09 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvjzv8syv5.fsf-monnier+emacs@gnu.org \
--to=bug-gnu-emacs@gnu.org \
--cc=64391@debbugs.gnu.org \
--cc=acohen@ust.hk \
--cc=eliz@gnu.org \
--cc=gregory@heytings.org \
--cc=mattias.engdegard@gmail.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.