From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Stefan Monnier via "Bug reports for GNU Emacs,
 the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
Newsgroups: gmane.emacs.bugs
Subject: bug#66394: 29.1; Make register-read-with-preview more useful
Date: Mon, 20 Nov 2023 12:33:57 -0500
Message-ID: <jwvjzqcxrnq.fsf-monnier+emacs@gnu.org>
References: <87il7ib6cu.fsf@posteo.net> <87sf67qqmp.fsf@web.de>
 <875y3386ep.fsf@posteo.net> <87a5sddh14.fsf@web.de>
 <8734y5vnj7.fsf@posteo.net> <87bkcslr18.fsf@web.de>
 <87y1fwtyrl.fsf@posteo.net> <87y1fut1wp.fsf@web.de>
 <87ttqgpjiz.fsf@posteo.net> <87wmvbibpr.fsf@web.de>
 <877cnb2n63.fsf@posteo.net> <8734xyc8z0.fsf@web.de>
 <87zg05rewi.fsf@posteo.net> <87ttqcg8gw.fsf@web.de>
 <87h6mcr8ol.fsf@posteo.net> <87r0l73029.fsf@web.de>
 <877cmdx8ud.fsf@posteo.net>
Reply-To: Stefan Monnier <monnier@iro.umontreal.ca>
Mime-Version: 1.0
Content-Type: text/plain
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="21387"; mail-complaints-to="usenet@ciao.gmane.io"
User-Agent: Gnus/5.13 (Gnus v5.13)
Cc: Michael Heerdegen <michael_heerdegen@web.de>, stefankangas@gmail.com,
 66394@debbugs.gnu.org
To: Thierry Volpiatto <thievol@posteo.net>
Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 20 18:37:20 2023
Return-path: <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org>
Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org>)
	id 1r58D2-0005J4-5v
	for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 20 Nov 2023 18:37:20 +0100
Original-Received: from localhost ([::1] helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <bug-gnu-emacs-bounces@gnu.org>)
	id 1r58Ck-0007AA-Ls; Mon, 20 Nov 2023 12:37:02 -0500
Original-Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1r58Ci-00079q-Uk
 for bug-gnu-emacs@gnu.org; Mon, 20 Nov 2023 12:37:01 -0500
Original-Received: from debbugs.gnu.org ([2001:470:142:5::43])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1r58Ci-0004MX-EZ
 for bug-gnu-emacs@gnu.org; Mon, 20 Nov 2023 12:37:00 -0500
Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1r58Ck-0000iL-Ht
 for bug-gnu-emacs@gnu.org; Mon, 20 Nov 2023 12:37:02 -0500
X-Loop: help-debbugs@gnu.org
Resent-From: Stefan Monnier <monnier@iro.umontreal.ca>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@gnu.org
Resent-Date: Mon, 20 Nov 2023 17:37:02 +0000
Resent-Message-ID: <handler.66394.B66394.17005018062720@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 66394
X-GNU-PR-Package: emacs
Original-Received: via spool by 66394-submit@debbugs.gnu.org id=B66394.17005018062720
 (code B ref 66394); Mon, 20 Nov 2023 17:37:02 +0000
Original-Received: (at 66394) by debbugs.gnu.org; 20 Nov 2023 17:36:46 +0000
Original-Received: from localhost ([127.0.0.1]:54442 helo=debbugs.gnu.org)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
 id 1r58CU-0000ho-Az
 for submit@debbugs.gnu.org; Mon, 20 Nov 2023 12:36:46 -0500
Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:18801)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <monnier@iro.umontreal.ca>) id 1r58CQ-0000hY-R7
 for 66394@debbugs.gnu.org; Mon, 20 Nov 2023 12:36:44 -0500
Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1])
 by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id B60E0442854;
 Mon, 20 Nov 2023 12:36:34 -0500 (EST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
 s=mail; t=1700501793;
 bh=qHeK5eP5bn3o/6GKjMuYpBC9C/PT31VnhyR5wYBFNI4=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=gtX+xEObATn6Z1nL5IAlOkXhKADv7wy3QOAEfcDg3cbHURJXZqMNTWaV9WDDp/uzp
 hrMIGOqzP8B2QxABEUcHrg4wppoS6xpbXI6P0tOYZdIkWJiXcMhE6Pq91zQsKD2XaH
 qJJOskH7srghpgFxp2I29eP7j6QwkLsbZb+oU2tzqkvbsEfJ59CJVjaq0c60sJ5pbc
 6fttW6GgDLYx3hi9b0Tl1gmWSn1dQEjT2SyCbhZSzbpCcBTzSHdU4pJsn64ui4fVkt
 RBBYu880hiWWlull7K48owpf88Bm58j+GkY9u2PWJQgOPQZi57H3SRXLJgfs+1W1NX
 8y6Yf0PVTqKqg==
Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
 by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 226FB442852;
 Mon, 20 Nov 2023 12:36:33 -0500 (EST)
Original-Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242])
 by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 0B128120387;
 Mon, 20 Nov 2023 12:36:33 -0500 (EST)
In-Reply-To: <877cmdx8ud.fsf@posteo.net> (Thierry Volpiatto's message of "Mon, 
 20 Nov 2023 06:00:26 +0000")
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
X-BeenThere: bug-gnu-emacs@gnu.org
List-Id: "Bug reports for GNU Emacs,
 the Swiss army knife of text editors" <bug-gnu-emacs.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-gnu-emacs>,
 <mailto:bug-gnu-emacs-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/bug-gnu-emacs>
List-Post: <mailto:bug-gnu-emacs@gnu.org>
List-Help: <mailto:bug-gnu-emacs-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-gnu-emacs>,
 <mailto:bug-gnu-emacs-request@gnu.org?subject=subscribe>
Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org
Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org
Xref: news.gmane.io gmane.emacs.bugs:274672
Archived-At: <http://permalink.gmane.org/gmane.emacs.bugs/274672>

> Ccing also Stefan monnier because for some reasons the patch when
> applied doesn't compile (when compiling Emacs) unless we add on
> top:
>
>     (cl--generic-prefill-dispatchers 0 (eql 'x) integer)
>
> following the advice of the compiler,

Indeed, this is needed because `register.el` is preloaded and method
dispatcher are generated&compiled "on the fly" but we don't want to
preload the compiler, so we want to pre-compile the dispatchers used
by the preloaded code.

> but I am not sure it is the way to do.

`cl--generic-prefill-dispatchers` is not guaranteed to be defined when
we load `register.el` (it's only defined if we loaded the non-compiled
version of `cl-generic.el`) so the above call should be in
`cl-generic.el` rather than in `register.el`.

I'd put it next to the following block:

    (cl--generic-prefill-dispatchers 0 (eql nil))
    (cl--generic-prefill-dispatchers window-system (eql nil))
    (cl--generic-prefill-dispatchers (terminal-parameter nil 'xterm--get-selection)
                                     (eql nil))
    (cl--generic-prefill-dispatchers (terminal-parameter nil 'xterm--set-selection)
                                     (eql nil))

which is already about dispatchers needed to support other files.


        Stefan