From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#66732: tree-sitter fontification doesn't update multi-line syntax reliably Date: Sat, 16 Dec 2023 14:57:04 -0500 Message-ID: References: <878r7s5cdf.fsf@honnef.co> <83fs1tbou1.fsf@gnu.org> <835y1zo3rw.fsf@gnu.org> <2ce274aa-6d01-4d0a-b10c-07f821343fed@gmail.com> <50920549-006c-0153-2471-02e41a3dada7@gutov.dev> <8c7cd429-bdc3-4fac-ad1c-fbad793bf1a0@gmail.com> <231ebcd1-ec30-0432-82e7-d63e11cd65f7@gutov.dev> <765D713E-9923-4F66-9044-9D69C104C9B0@gmail.com> <33fe5d61-5022-67c5-6a65-babde4fb7f91@gutov.dev> <92CACD38-9534-4A07-8DE3-CE8408272FB6@gmail.com> <59CC46F7-867E-4C74-83EC-49B41DF0FAB8@gmail.com> <2C418114-3773-4D62-90CB-E4C7F1B7D467@gmail.com> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26408"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Dmitry Gutov , Eli Zaretskii , 66732@debbugs.gnu.org, dominik@honnef.co To: Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 16 20:58:25 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rEano-0006iv-TQ for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 16 Dec 2023 20:58:25 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rEanT-0006yO-QW; Sat, 16 Dec 2023 14:58:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rEanS-0006vI-2e for bug-gnu-emacs@gnu.org; Sat, 16 Dec 2023 14:58:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rEanR-00033R-Py for bug-gnu-emacs@gnu.org; Sat, 16 Dec 2023 14:58:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rEanS-00086y-4D for bug-gnu-emacs@gnu.org; Sat, 16 Dec 2023 14:58:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 16 Dec 2023 19:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66732 X-GNU-PR-Package: emacs Original-Received: via spool by 66732-submit@debbugs.gnu.org id=B66732.170275663831127 (code B ref 66732); Sat, 16 Dec 2023 19:58:02 +0000 Original-Received: (at 66732) by debbugs.gnu.org; 16 Dec 2023 19:57:18 +0000 Original-Received: from localhost ([127.0.0.1]:56107 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEamj-00085z-US for submit@debbugs.gnu.org; Sat, 16 Dec 2023 14:57:18 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:21759) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEamf-00085h-9A for 66732@debbugs.gnu.org; Sat, 16 Dec 2023 14:57:16 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 1ECBD80C07; Sat, 16 Dec 2023 14:57:07 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1702756626; bh=2R4VX+BnO1++zDguz/Xp/ozUvynmmkNriEoOoEb7zps=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=VQRiiobE+HZ04UibKB0AnVD/4M7nVrws9BLMb4jOkzScbBE+m1HG5AGAPXgQv9lh5 8ZpfTgDCaCIIpxYo+f6nev5oouO2N/pQ0cYF2hIiAPmycxex0u3BbpRYf5UI0pHMad m2KGVSU4ScrUbSiWaj5+Oe9xckTOHEll96iAIU2lMITJkg196mhONUaAVwvDnR1mnA GqgvmIh+1Lb0GVWeCyeZAHd4PRLzDvRJ835IlUfn5ME8yMBdg3SVbWpzdbBmQ0x68V /3zbieCHcxzXOwgeA4NAyabGAM4JhFAlJ0/pU8mAZ3qMOra+ra/R8u0mh9E+YiMT9A rpGl8mx7LZIsw== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 17B1280B5E; Sat, 16 Dec 2023 14:57:06 -0500 (EST) Original-Received: from pastel (65-110-221-238.cpe.pppoe.ca [65.110.221.238]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id D9CAA120E51; Sat, 16 Dec 2023 14:57:05 -0500 (EST) In-Reply-To: <2C418114-3773-4D62-90CB-E4C7F1B7D467@gmail.com> (Yuan Fu's message of "Sat, 16 Dec 2023 11:18:33 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:276378 Archived-At: > +(defun treesit--pre-redisplay (&rest _) > + (treesit-update-ranges) > + (dolist (parser (treesit-parser-list nil nil t)) > + (treesit-parser-root-node parser))) Note that `pre-redisplay-functions` is called often and can be called N times for a single redisplay (if the buffer is displayed in N windows), so we should try and make sure we only do the hard work if there's actually been a change since the last time. [ And the code should probably come with a comment explaining why calling `treesit-parser-root-node` and ignoring its return value is useful here. ] Stefan