From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#69132: [ELPA] Remove jQuery from elpa.gnu.org Date: Thu, 15 Feb 2024 10:37:30 -0500 Message-ID: References: <87jzn6g7ep.fsf@posteo.net> <87h6iap2lz.fsf@posteo.net> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40052"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 69132@debbugs.gnu.org To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Feb 15 16:37:57 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1radoC-000ACz-TS for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 15 Feb 2024 16:37:57 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rado1-0007QX-EP; Thu, 15 Feb 2024 10:37:45 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1radnz-0007Q9-Fc for bug-gnu-emacs@gnu.org; Thu, 15 Feb 2024 10:37:43 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1radnz-00035N-7R for bug-gnu-emacs@gnu.org; Thu, 15 Feb 2024 10:37:43 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1radoH-0001Ok-M9 for bug-gnu-emacs@gnu.org; Thu, 15 Feb 2024 10:38:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Feb 2024 15:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69132 X-GNU-PR-Package: emacs Original-Received: via spool by 69132-submit@debbugs.gnu.org id=B69132.17080114795361 (code B ref 69132); Thu, 15 Feb 2024 15:38:01 +0000 Original-Received: (at 69132) by debbugs.gnu.org; 15 Feb 2024 15:37:59 +0000 Original-Received: from localhost ([127.0.0.1]:56786 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1radoE-0001OP-Lf for submit@debbugs.gnu.org; Thu, 15 Feb 2024 10:37:59 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:63170) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1radoC-0001OA-26 for 69132@debbugs.gnu.org; Thu, 15 Feb 2024 10:37:57 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 9DF86441478; Thu, 15 Feb 2024 10:37:31 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1708011449; bh=Mbh6AAkOgtntOLbNoaE6xZhT+Mk0mPFmaNS7ayV8eKQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Kie58gnbxgO+fUqWYCdmaqVBtsVsR4bGqld/JqxouITcxrz3aVehvwDUpge8c9CR7 Dr8z3RGwnA6I6KVjRgWxWYl7jgMPD5B2neMbjZTX6+Ql5R7C/7Y4Ja+4q6+Qs/MgcA 0pYwAy8ZiB21DeRF6EW1uOmXIpuruGmrego8wyc2WrGaZJn7mKp8aOniP7Ot47FOi7 97/XYzdF1xsjPdwTX0EW5Sznieq/0seDvE2PITDzSHsITYAnJVjjohNMuCP5TVhLlu IHnwCxQhB9cpidrsiow2lKweddsVKgwWSnm5vrAVhl57Yo+FtI/TOUgLuDApgi/D+h 9OHgDbIHjqgqQ== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 71ED9441444; Thu, 15 Feb 2024 10:37:29 -0500 (EST) Original-Received: from alfajor (unknown [23.233.149.155]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 44252120667; Thu, 15 Feb 2024 10:37:29 -0500 (EST) In-Reply-To: <87h6iap2lz.fsf@posteo.net> (Philip Kaludercic's message of "Thu, 15 Feb 2024 08:12:56 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:280062 Archived-At: >> Works for me, but I'm not using an "older browser" =F0=9F=99=81 > I have a few older machines that I could try it out on. I have plenty of old machines, but they're all running up-to-date software =F0=9F=99=82 >> I know very little about Javascript, but I'm curious: can't we add the >> `input` element directly in the HTML file, and skip those first 4 lines = or so? > Of course, I just replicated what the jquery plugin did. I suppose > the idea was to not have a broken search field labelled "Search > packages...", if there is no Javascript to make it work in the > first place. FWIW this here user prefers to see the features that he's missing when he's using a non-Javascript browser. Anyway, it's only tangentially related to your patch, so we can keep it for later. Regarding your patch, I see you remove all the "reset" in the CSS. I'm not really sure we did that, but it's also not described and explained in the commit log of your patch. > The idea is just to not use CSS classes to pinpoint specific Elements in > the DOM. That is what IDs are for (ideally the "ID -> elements" map > should be injective). I needed that to use document.getElementById in > the new script. > Should I update the commit messages to explain the change? Yes, please. While we're not picky about commit messages in (Non)GNU ELPA packages, we should be careful to use good commit messages in the `main` (and `elpa-admin`) branches. Even more so for non-ELisp files since we can't assume familiarity. Stefan