From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Doc of deprecated INITIAL-INPUT arg of completing-read Date: Thu, 15 Feb 2024 13:39:52 -0500 Message-ID: References: <87v8smt9lp.fsf@web.de> <87h6ic1l23.fsf@vagabond.tim-landscheidt.de> <87le7owawi.fsf@vagabond.tim-landscheidt.de> <87sf1u5e9c.fsf@vagabond.tim-landscheidt.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24494"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Michael Heerdegen , emacs-devel@gnu.org To: Tim Landscheidt Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Feb 15 19:40:42 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ragf4-00069l-ET for ged-emacs-devel@m.gmane-mx.org; Thu, 15 Feb 2024 19:40:42 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rageQ-0002IT-7C; Thu, 15 Feb 2024 13:40:02 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rageN-0002I1-Tv for emacs-devel@gnu.org; Thu, 15 Feb 2024 13:39:59 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rageK-0002Vx-Le for emacs-devel@gnu.org; Thu, 15 Feb 2024 13:39:59 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id D00D71000C3; Thu, 15 Feb 2024 13:39:54 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1708022393; bh=7dIv4xwIvQN1zlRXA9s1ptnbEbpBkWI0i14rp+NgMmY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=ZeHOkevGiduNnmfGRV0sIpk9aBUzTd/waHoy9tei9yTzFcaUopu4oePpLw7wlXDF8 5QeF2vglLAuEiLEOOC95yJAKdlGlB7U9sHFe1vXnYk8bExqaauchteaAmklzjqvC7M Fx61og3dhnj0QF0RGOiFkZqkygF/MLKnmiPOg5XVvLlcAGRCAEgZy7OL1WFV8G+TmP nfC/cMf+gNSQPWEroCynlRAc+gnUmEZzO0Xr7k4GWGTaURvV2+Y/rDjBhpQ5FF8Zu/ TH2vWXN2oqBPxuotXVfGPBiibLRtTEAIXl2wGGO0dvrpxs6+1GOp6UmGLmrkHIB2Xk ZJbfhXLsXomUQ== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id CE93E10004B; Thu, 15 Feb 2024 13:39:53 -0500 (EST) Original-Received: from alfajor (unknown [23.233.149.155]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id ABFDF12062C; Thu, 15 Feb 2024 13:39:53 -0500 (EST) In-Reply-To: <87sf1u5e9c.fsf@vagabond.tim-landscheidt.de> (Tim Landscheidt's message of "Thu, 15 Feb 2024 08:21:35 +0000") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:316241 Archived-At: > The docstring for completing-read (GNU Emacs 28.3) says re- > garding INITIAL-INPUT: > > | If INITIAL-INPUT is non-nil, insert it in the minibuffer initially, > | with point positioned at the end. If it is (STRING . POSITION), the > | initial input is STRING, but point is placed at _zero-indexed_ > | position POSITION in STRING. (*Note* that this is different from > | =E2=80=98read-from-minibuffer=E2=80=99 and related functions, which u= se one-indexing > | for POSITION.) This feature is deprecated--it is best to pass nil > | for INITIAL-INPUT and supply the default value DEF instead. The > | user can yank the default value into the minibuffer easily using > | M-n. > > If one follows this recommendation (setting INITIAL-INPUT to > nil and passing the original value as DEF), the user is not > made aware of the original INITIAL-INPUT value until he > presses M-n. Oh, you mean we should add that the default should be passed to `format-prompt`? I guess that would help, indeed. Of course, even better would be to call `format-prompt` automatically. I just don't know how to do that conveniently without breaking compatibility. Maybe something like (unless (memq (aref prompt (- (length prompt) 1)) '(?: ?? ?\s)) (setq prompt (format-prompt prompt default))) ? > For example, when I use M-x compile RET, I typically do not > want to enter a different value, but amend the existing one > by adding/changing the target or setting an option. I suspect this depends on the user. > But even in the basic case of C-x C-f, if I want to find a file > upwards of default-directory, the two extra keystrokes harmonize > well with wanting to do something different, so it never occured to me > that Emacs should protect me from them. =F0=9F=99=82 FWIW, it's almost never necessary in `C-x C-f` since you can type `../` to "go up", `~/` to go home, and you don't need to type anything at all to go back to the root. Stefan