From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#67455: (Record source position, etc., in doc strings, and use this in *Help* and backtraces.) Date: Wed, 27 Mar 2024 08:23:52 -0400 Message-ID: References: Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5376"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , 67455@debbugs.gnu.org To: Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Mar 27 13:25:38 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rpSLX-00015f-Ek for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 27 Mar 2024 13:25:35 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rpSLA-0005mM-Lf; Wed, 27 Mar 2024 08:25:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rpSL0-0005m8-2x for bug-gnu-emacs@gnu.org; Wed, 27 Mar 2024 08:25:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rpSKz-0006tT-QL for bug-gnu-emacs@gnu.org; Wed, 27 Mar 2024 08:25:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rpSKz-0001hN-SK for bug-gnu-emacs@gnu.org; Wed, 27 Mar 2024 08:25:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 27 Mar 2024 12:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67455 X-GNU-PR-Package: emacs Original-Received: via spool by 67455-submit@debbugs.gnu.org id=B67455.17115422426381 (code B ref 67455); Wed, 27 Mar 2024 12:25:01 +0000 Original-Received: (at 67455) by debbugs.gnu.org; 27 Mar 2024 12:24:02 +0000 Original-Received: from localhost ([127.0.0.1]:35928 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rpSK2-0001eq-7L for submit@debbugs.gnu.org; Wed, 27 Mar 2024 08:24:02 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:62196) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rpSK0-0001eM-DD for 67455@debbugs.gnu.org; Wed, 27 Mar 2024 08:24:00 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id E8CF344123C; Wed, 27 Mar 2024 08:23:54 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1711542233; bh=2VIMf2lKriAiylS5JyXC14jrzjhkq+nvfQfX5Kd46uk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=nGtDcIc2QBIobor2/A/2auj3a9BOItavNvT4qq6swnwtOZFhbny1IUXv0TNVS+R+d GXnYO/FV0dWJ1G2ALg/b3mqgzcPyZ982QoHNJ7LiaaFl9i8WuaXHWHtgnpzbJ19Jys hDy6rX+xzAYxdyioYIvZfvBOWcNSy6eSmQc52XgrP0XzxFlrbQt+uv1gApfRjT323p K+FKr0EPPpE4wMkqwjYU+zZLcvIQEVF++ureYrbwloNc0aS5EHoUF0nREOW2NWNb2q GRRpeoa0yv5/Dk3TadDXjumvYu5Ujx/Gc/ZSZR3ZKR0OL87chmgcFfG7Emriv7ZHu9 Hb49UdQ31do2Q== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 84B36440175; Wed, 27 Mar 2024 08:23:53 -0400 (EDT) Original-Received: from pastel (unknown [45.72.199.112]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 618991201BE; Wed, 27 Mar 2024 08:23:53 -0400 (EDT) In-Reply-To: (Alan Mackenzie's message of "Wed, 27 Mar 2024 03:35:41 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:282135 Archived-At: >> > r-p-defined-s positions only lambdas and NAMEs defined by defun, >> > defmacro, defvar, .... (around 50 defining symbols). r-p-s positions >> > every symbol apart from nil. They have different purposes. r-p-d-s >> > gets info for the doc strings, which requires SWPs only for some >> > symbols. r-p-s is needed to get warning message locations. Were r-p-s >> > used for the doc string position information, most of the symbols would >> > need to be stripped of their positions before the form could be used. >> > It is simpler and faster not to position them at all. >> In terms of code, I can't see why it'd be simpler: we already have the >> r-p-s function, .... > We also already have r-p-d-s. You're playing on words here: we don't "already have" `r-p-d-s` on master. > Both functions (together with plain read) have read0 as their core > engine. The enhancement to read0 to support r-p-d-s was only moderate > in size and not complicated to anybody who understands finite > state machines. Just because it's not a complex change doesn't mean it's "simpler" than no change at all. >> .... and we already have a function to strip that info when we don't >> need it any more, so it would be less new code to write if we just >> used r-p-s, I think. > I think you're envisaging an extensive redesign where SWPs would not be > tightly and individually controlled as they are at the moment, but > instead would be created en masse and stripped en masse a bit later. Yes, that's the starting design I had in mind (and that I described a few emails back). it's also what we do in the byte-compilation case, so it's code we already have and use. The "en masse" doesn't make it complex. Stefan