From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master e720ba62193 1/2: (mouse-wheel-buttons): Map old-style wheel buttons to actual wheel events Date: Tue, 09 Apr 2024 16:39:57 -0400 Message-ID: References: <171267304154.21960.14298364323940508129@vcs2.savannah.gnu.org> <20240409143042.278CDC12C36@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10452"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Eshel Yaron Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Apr 09 22:41:02 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ruIH7-0002VK-8j for ged-emacs-devel@m.gmane-mx.org; Tue, 09 Apr 2024 22:41:01 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ruIGJ-0006hr-QU; Tue, 09 Apr 2024 16:40:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ruIGH-0006hX-V7 for emacs-devel@gnu.org; Tue, 09 Apr 2024 16:40:09 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ruIGG-0006bW-Am for emacs-devel@gnu.org; Tue, 09 Apr 2024 16:40:09 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 724051000FC; Tue, 9 Apr 2024 16:40:05 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1712695204; bh=Q1ed1nI+orkey63Sv+7qOGL4zgVIA3GDOaonuPElbxk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=FrV8Gj/xkuZMnFME5Dvr8e2/DRoWY6QlfGFuhRqwQzLsC9N/FGxd8yk8mYy4LiTh2 ybxBvVkIiijKZrn23K8W0WfpSacoT+ysnG9/4tMu/16Y/yEzLA7ul9arBs3LfrDAE5 cnyxdPWamCfbNF3Ct7zSvBMTbmtIJWfNrty+fsbWRWg1g3hrKESS6/a2XGC0RWfdPG QvQsilFYvZkNgaDFdszCCWR5iNtBgC5Zv/WalyhR4nFQvwUmn+vRjkhq9FDLCWk6ox TgOmqlhEcI+1J8EODSMiCjIvhrAavpyVbkB3m9D9VAwVClpMnRAK3FPpoNEcQQh8oQ SChtwXKCJ9VwA== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 8950B10004A; Tue, 9 Apr 2024 16:40:04 -0400 (EDT) Original-Received: from pastel (unknown [45.72.201.215]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 683BB120470; Tue, 9 Apr 2024 16:40:04 -0400 (EDT) In-Reply-To: (Eshel Yaron's message of "Tue, 09 Apr 2024 19:29:39 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:317649 Archived-At: > I wonder whether/why we should keep the bindings that use > mouse-wheel-up/down-event here. Do I understand correctly that since we > already bind wheel-down/up directly, we should now be able to simply > remove these additional bindings? I had an earlier patch which was "more radical" in this way, but in the end went with this half-way patch where people can set `mouse-wheel-buttons` to nil and recover the old behavior. We could remove most of those (if not all) uses of `mouse-wheel-up/down/left/right-event`, but I don't think there's a hurry to do that. Admittedly, the ones in `completion-preview.el` could go because they're new in Emacs-30 so there's no previous behavior to preserve. Stefan