From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via Users list for the GNU Emacs text editor Newsgroups: gmane.emacs.help Subject: Re: Indentation of hashes (?) in perl-mode Date: Fri, 05 Jul 2024 10:03:07 -0400 Message-ID: References: <878qz1grsd.fsf@vagabond.tim-landscheidt.de> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13684"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) To: help-gnu-emacs@gnu.org Cancel-Lock: sha1:kSfONXcgGa5pFbH26fiHj6kch6E= Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jul 05 16:04:15 2024 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sPjXr-0003Qw-6x for geh-help-gnu-emacs@m.gmane-mx.org; Fri, 05 Jul 2024 16:04:15 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPjXA-00018m-Va; Fri, 05 Jul 2024 10:03:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPjX5-00018K-8w for help-gnu-emacs@gnu.org; Fri, 05 Jul 2024 10:03:28 -0400 Original-Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPjX3-0002ti-QL for help-gnu-emacs@gnu.org; Fri, 05 Jul 2024 10:03:27 -0400 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1sPjWx-00024T-Eo for help-gnu-emacs@gnu.org; Fri, 05 Jul 2024 16:03:19 +0200 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=116.202.254.214; envelope-from=geh-help-gnu-emacs@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.help:147078 Archived-At: > when writing anonymous subroutines for Find::File::find, I > get the following indentation with Emacs 29.3's perl-mode: > > | find ({ wanted => sub { > | return; > | }, follow => 1 }, '/tmp'); > > IMHO it would seem more natural if the last line's opening > bracket was in the first column (i. e., no indentation). [ In my view it's the `return` above that's wrong. 🙂 ] But what about: find ({ wanted => sub { return; }, follow => 1, other => 3}, '/tmp'); Would you want the indentation I just used or would you prefer find ({ wanted => sub { return; }, follow => 1, other => 3}, '/tmp'); Usually indentation rules look only at the text that comes *before*, so the indentation of `return` and of the line with `follow` should be the same regardless of what comes on subsequent lines. > Is it possible to make perl-mode indent these structures > more naturally? (I'm open to other ways to phrase this code > as well.) I'd suggest find ({ wanted => sub { return; }, follow => 1, other => 3}, '/tmp'); BTW, I just installed on `master` the patch below which fixes the indentation of `return`. Stefan diff --git a/lisp/progmodes/perl-mode.el b/lisp/progmodes/perl-mode.el index 68685fb6625..ff71970d41b 100644 --- a/lisp/progmodes/perl-mode.el +++ b/lisp/progmodes/perl-mode.el @@ -1130,14 +1130,7 @@ perl-calculate-indent ;; add the perl-brace-imaginary-offset. (progn (skip-chars-backward " \t") (if (bolp) 0 perl-brace-imaginary-offset)) - ;; If the openbrace is preceded by a parenthesized exp, - ;; move to the beginning of that; - ;; possibly a different line - (progn - (if (eq (preceding-char) ?\)) - (forward-sexp -1)) - ;; Get initial indentation of the line we are on. - (current-indentation))))))))) + (perl-indent-new-calculate 'virtual)))))))) (defun perl-backward-to-noncomment () "Move point backward to after the first non-white-space, skipping comments."