Indentation of hashes (?) in perl-mode

Indentation of hashes (?) in perl-mode

[Tim Landscheidt]

Hi,

when writing anonymous subroutines for Find::File::find, I
get the following indentation with Emacs 29.3's perl-mode:

| find ({ wanted => sub {
|     return;
|         }, follow => 1 }, '/tmp');

IMHO it would seem more natural if the last line's opening
bracket was in the first column (i. e., no indentation).

A similar question was asked on Stack Exchange
(https://emacs.stackexchange.com/questions/78606/perl-mode-brace-indentation)
with the additional condition "without switching to
cperl-mode".

Is it possible to make perl-mode indent these structures
more naturally?  (I'm open to other ways to phrase this code
as well.)

TIA,
Tim

Re: Indentation of hashes (?) in perl-mode

[Stefan Monnier via Users list for the GNU Emacs text editor]

> when writing anonymous subroutines for Find::File::find, I
> get the following indentation with Emacs 29.3's perl-mode:
>
> | find ({ wanted => sub {
> |     return;
> |         }, follow => 1 }, '/tmp');
>
> IMHO it would seem more natural if the last line's opening
> bracket was in the first column (i. e., no indentation).

[ In my view it's the `return` above that's wrong. 🙂  ]
But what about:

    find ({ wanted => sub {
                return;
            }, follow => 1,
            other => 3},
          '/tmp');

Would you want the indentation I just used or would you prefer

    find ({ wanted => sub {
        return;
    }, follow => 1,
            other => 3},
          '/tmp');

Usually indentation rules look only at the text that comes *before*, so
the indentation of `return` and of the line with `follow` should be the
same regardless of what comes on subsequent lines.

> Is it possible to make perl-mode indent these structures
> more naturally?  (I'm open to other ways to phrase this code
> as well.)

I'd suggest

    find ({ wanted => sub {
                return;
            }, follow => 1,
            other => 3},
          '/tmp');

BTW, I just installed on `master` the patch below which fixes the
indentation of `return`.


        Stefan


diff --git a/lisp/progmodes/perl-mode.el b/lisp/progmodes/perl-mode.el
index 68685fb6625..ff71970d41b 100644
--- a/lisp/progmodes/perl-mode.el
+++ b/lisp/progmodes/perl-mode.el
@@ -1130,14 +1130,7 @@ perl-calculate-indent
             ;; add the perl-brace-imaginary-offset.
             (progn (skip-chars-backward " \t")
                    (if (bolp) 0 perl-brace-imaginary-offset))
-            ;; If the openbrace is preceded by a parenthesized exp,
-            ;; move to the beginning of that;
-            ;; possibly a different line
-            (progn
-              (if (eq (preceding-char) ?\))
-                  (forward-sexp -1))
-              ;; Get initial indentation of the line we are on.
-              (current-indentation)))))))))
+            (perl-indent-new-calculate 'virtual))))))))
 
 (defun perl-backward-to-noncomment ()
   "Move point backward to after the first non-white-space, skipping comments."