From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Please check-in Belanger's Calc patches Date: 21 Jul 2004 11:44:14 -0400 Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Message-ID: References: <87658qlgte.fsf@floss.red-bean.com> <87k6wyefvu.fsf@floss.red-bean.com> <87r7r58kzh.fsf@truman.edu> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1090424687 2295 80.91.224.253 (21 Jul 2004 15:44:47 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 21 Jul 2004 15:44:47 +0000 (UTC) Cc: kfogel@red-bean.com, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jul 21 17:44:36 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1BnJGl-0001Qo-00 for ; Wed, 21 Jul 2004 17:44:36 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1BnJJY-0005oI-M5 for ged-emacs-devel@m.gmane.org; Wed, 21 Jul 2004 11:47:28 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1BnJJQ-0005nQ-Fx for emacs-devel@gnu.org; Wed, 21 Jul 2004 11:47:20 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1BnJJP-0005mt-AM for emacs-devel@gnu.org; Wed, 21 Jul 2004 11:47:19 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1BnJJP-0005mq-6Y for emacs-devel@gnu.org; Wed, 21 Jul 2004 11:47:19 -0400 Original-Received: from [132.204.24.67] (helo=mercure.iro.umontreal.ca) by monty-python.gnu.org with esmtp (Exim 4.34) id 1BnJGZ-0002g8-Rc for emacs-devel@gnu.org; Wed, 21 Jul 2004 11:44:23 -0400 Original-Received: from asado.iro.umontreal.ca (asado.iro.umontreal.ca [132.204.24.84]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id 87E2EB3027B; Wed, 21 Jul 2004 11:44:14 -0400 (EDT) Original-Received: by asado.iro.umontreal.ca (Postfix, from userid 20848) id 2C2758CA23; Wed, 21 Jul 2004 11:44:14 -0400 (EDT) Original-To: belanger@truman.edu In-Reply-To: <87r7r58kzh.fsf@truman.edu> Original-Lines: 22 User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50 X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=0, requis 5) X-MailScanner-From: monnier@iro.umontreal.ca X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:25863 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:25863 >> [...] >>> calc-invocation-macro, calc-show-banner): Define these as part of >>> `calc-mode-var-list's initialization, instead of using defvar. >> >> Not defining those vars with defvar means that the byte-compiler doesn't >> get the info it wants. It doesn't necessarily lead to wrong code, but it's >> very bad coding style and can prevent optimizations (which are admittedly >> not currently implemented). It also leads to lots and lots of spurious >> warnings during byte-compilation. > Calc stores those variables in calc-mode-var-list so that functions > (which store and reset those variables) can easily access them. > There are about four functions which do this. If these variables are > set individually by defvar, then the store-reset functions would have > to be redone. Restoring calc-mode-var-list is easier, but redoing the > functions is doable, no doubt. But as a short-term fix, can't they be both defvar'd and listed in calc-mode-var-list? Stefan