From: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: kfogel@red-bean.com, emacs-devel@gnu.org
Subject: Re: Please check-in Belanger's Calc patches
Date: 21 Jul 2004 11:44:14 -0400 [thread overview]
Message-ID: <jwvischfjrm.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87r7r58kzh.fsf@truman.edu>
>> [...]
>>> calc-invocation-macro, calc-show-banner): Define these as part of
>>> `calc-mode-var-list's initialization, instead of using defvar.
>>
>> Not defining those vars with defvar means that the byte-compiler doesn't
>> get the info it wants. It doesn't necessarily lead to wrong code, but it's
>> very bad coding style and can prevent optimizations (which are admittedly
>> not currently implemented). It also leads to lots and lots of spurious
>> warnings during byte-compilation.
> Calc stores those variables in calc-mode-var-list so that functions
> (which store and reset those variables) can easily access them.
> There are about four functions which do this. If these variables are
> set individually by defvar, then the store-reset functions would have
> to be redone. Restoring calc-mode-var-list is easier, but redoing the
> functions is doable, no doubt.
But as a short-term fix, can't they be both defvar'd and listed in
calc-mode-var-list?
Stefan
next prev parent reply other threads:[~2004-07-21 15:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-13 16:09 Please check-in Belanger's Calc patches Tacvek
2004-07-13 17:42 ` Karl Fogel
2004-07-14 3:40 ` Jay Belanger
2004-07-14 18:27 ` Richard Stallman
2004-07-14 16:00 ` Karl Fogel
2004-07-20 17:40 ` Karl Fogel
2004-07-21 14:07 ` Stefan
2004-07-21 14:59 ` Jay Belanger
2004-07-21 15:44 ` Stefan Monnier [this message]
2004-07-21 17:16 ` Jay Belanger
2004-07-21 17:42 ` Jay Belanger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvischfjrm.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=kfogel@red-bean.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.