From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: unicode build: "comparison is always true" warnings Date: Fri, 23 Nov 2007 10:09:52 -0500 Message-ID: References: <87oddltv7f.fsf@everybody.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1195830606 9863 80.91.229.12 (23 Nov 2007 15:10:06 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 23 Nov 2007 15:10:06 +0000 (UTC) Cc: emacs-devel@gnu.org To: mah@everybody.org (Mark A. Hershberger) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 23 16:10:13 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IvaAW-0006HO-UF for ged-emacs-devel@m.gmane.org; Fri, 23 Nov 2007 16:10:13 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IvaAI-0001MU-9b for ged-emacs-devel@m.gmane.org; Fri, 23 Nov 2007 10:09:58 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IvaAF-0001MN-Ju for emacs-devel@gnu.org; Fri, 23 Nov 2007 10:09:55 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IvaAE-0001M8-77 for emacs-devel@gnu.org; Fri, 23 Nov 2007 10:09:55 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IvaAE-0001M5-49 for emacs-devel@gnu.org; Fri, 23 Nov 2007 10:09:54 -0500 Original-Received: from tomts10.bellnexxia.net ([209.226.175.54] helo=tomts10-srv.bellnexxia.net) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IvaAD-0006lA-In for emacs-devel@gnu.org; Fri, 23 Nov 2007 10:09:53 -0500 Original-Received: from pastel.home ([74.12.207.44]) by tomts10-srv.bellnexxia.net (InterMail vM.5.01.06.13 201-253-122-130-113-20050324) with ESMTP id <20071123150952.JPLS1733.tomts10-srv.bellnexxia.net@pastel.home> for ; Fri, 23 Nov 2007 10:09:52 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 82E618197; Fri, 23 Nov 2007 10:09:52 -0500 (EST) In-Reply-To: <87oddltv7f.fsf@everybody.org> (Mark A. Hershberger's message of "Thu, 22 Nov 2007 23:57:40 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.50 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Solaris 8 (1) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:83968 Archived-At: > I'm working on providing snapshots of the unicode branch and have been > getting a ton of these messages: > warning: comparison is always true due to limited range of data type > Most are in syntax.c, but one shows up in search.c. These are difficult to eliminate without making the code uglier. IIRC the issue is typically that there's are generic macros to handle characters and they can be used on any character (not just on 8-bit chars). But when you use it on a "char", part of the macro becomes trivially optimizable and gcc thinks this may in fact indicate the presence of a bug. Maybe we should just silence these warnings with the appropriate -Wno-. > There is also a warning from movemail.c: > warning: the use of `mktemp' is dangerous, better use `mkstemp' or > `mkdtemp' This one looks bad. Stefan