* Quit within sit-for
@ 2008-06-09 13:54 Stefan Monnier
2008-06-09 14:19 ` Andreas Schwab
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Monnier @ 2008-06-09 13:54 UTC (permalink / raw)
To: Andreas Schwab; +Cc: emacs-devel
In your recent change to minibuffer.el you added:
;; A quit during sit-for should be (re-)read as
;; abort-recursive-edit
(inhibit-quit t))
Other than the lack of "." at the end of the sentence, I'm worried that
if this fixes a bug, the bug is a lot more widespread. But I must say
I don't understand the comment.
The comment seems to say that C-g within the sit-for be "(re-)read"
differently than if it had been typed at some other time. Is that
really what your change is about? If so, that sounds wrong (the
sit-for is only a display artifact and should ideally in no way
influence Emacs's behavior).
Or is it that without your change Emacs does behave differently within
the sit-for than outside of it and your change tries to bring the two
behaviors a bit closer to each other?
Stefan
PS: *Please* reply with more than 1 line.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Quit within sit-for
2008-06-09 13:54 Quit within sit-for Stefan Monnier
@ 2008-06-09 14:19 ` Andreas Schwab
2008-06-10 1:21 ` Stefan Monnier
0 siblings, 1 reply; 3+ messages in thread
From: Andreas Schwab @ 2008-06-09 14:19 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> The comment seems to say that C-g within the sit-for be "(re-)read"
> differently than if it had been typed at some other time.
It's not re-read, but discarded (after quitting). You have to quit
again to exit the minibuffer, which is a highly annoying regression.
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Quit within sit-for
2008-06-09 14:19 ` Andreas Schwab
@ 2008-06-10 1:21 ` Stefan Monnier
0 siblings, 0 replies; 3+ messages in thread
From: Stefan Monnier @ 2008-06-10 1:21 UTC (permalink / raw)
To: Andreas Schwab; +Cc: emacs-devel
>> The comment seems to say that C-g within the sit-for be "(re-)read"
>> differently than if it had been typed at some other time.
> It's not re-read, but discarded (after quitting). You have to quit
> again to exit the minibuffer, which is a highly annoying regression.
Oh, I see, because the C-g typed during sit-for would otherwise (without
the sit-for delay thingy) be typed while being at "toplevel".
That makes sense, thanks. I'll adjust the comment to make it more
understandable (to me anyway).
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-06-10 1:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-06-09 13:54 Quit within sit-for Stefan Monnier
2008-06-09 14:19 ` Andreas Schwab
2008-06-10 1:21 ` Stefan Monnier
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.