From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: sans-serif name change Date: Wed, 25 Jun 2008 10:00:38 -0400 Message-ID: References: <87hcbi9vbg.fsf@catnip.gol.com> <4862198F.4060305@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1214402528 14996 80.91.229.12 (25 Jun 2008 14:02:08 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 25 Jun 2008 14:02:08 +0000 (UTC) Cc: miles@gnu.org, schwab@suse.de, emacs-devel@gnu.org, Jason Rumney To: Kenichi Handa Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jun 25 16:02:52 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KBVZw-0005Vz-Dp for ged-emacs-devel@m.gmane.org; Wed, 25 Jun 2008 16:02:32 +0200 Original-Received: from localhost ([127.0.0.1]:38847 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KBVZ6-0007P1-S1 for ged-emacs-devel@m.gmane.org; Wed, 25 Jun 2008 10:01:40 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KBVYI-0006Ws-RA for emacs-devel@gnu.org; Wed, 25 Jun 2008 10:00:50 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KBVYH-0006Vg-Az for emacs-devel@gnu.org; Wed, 25 Jun 2008 10:00:50 -0400 Original-Received: from [199.232.76.173] (port=45130 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KBVYH-0006VT-0Z for emacs-devel@gnu.org; Wed, 25 Jun 2008 10:00:49 -0400 Original-Received: from ironport2-out.pppoe.ca ([206.248.154.182]:44632 helo=ironport2-out.teksavvy.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KBVY9-0000Gb-IJ; Wed, 25 Jun 2008 10:00:41 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AuoEAHzsYUhFxIdG/2dsb2JhbACBW7BigW4 X-IronPort-AV: E=Sophos;i="4.27,702,1204520400"; d="scan'208";a="23184074" Original-Received: from 69-196-135-70.dsl.teksavvy.com (HELO pastel.home) ([69.196.135.70]) by ironport2-out.teksavvy.com with ESMTP; 25 Jun 2008 10:00:39 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 161317F1C; Wed, 25 Jun 2008 10:00:38 -0400 (EDT) In-Reply-To: (Kenichi Handa's message of "Wed, 25 Jun 2008 20:36:39 +0900") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:99923 Archived-At: >> My guess is that the `-' in Sans-Serif is being treated as a separator >> character, and causes Emacs to look for a font called Serif with the >> foundry Sans, or something similar. > Yes. I didn't change that behaviour for backward > compatibility, but as face has the attribute :foundy now, it > may be ok to break that compatibility. > The parsing of XXX-YYY as FOUNDRY-FAMILY is now done in > the function set-face-attribute as this: > (if (and (eq (car args) :family) > (stringp (cadr args)) > (string-match "\\([^-]*\\)-\\([^-]*\\)" (cadr args))) > (let ((foundry (match-string 1 (cadr args))) > (family (match-string 2 (cadr args)))) > (internal-set-lisp-face-attribute face :foundry > (purecopy foundry) > where) > (internal-set-lisp-face-attribute face :family > (purecopy family) > where)) > (internal-set-lisp-face-attribute face (car args) > (purecopy (cadr args)) > where))) Maybe this "FOUNDRY-FAMILY" fallback code could be moved to the same code that handles face-font-family-alternatives? Stefan