From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Kenichi Handa <handa@m17n.org>
Cc: miles@gnu.org, schwab@suse.de, emacs-devel@gnu.org,
Jason Rumney <jasonr@gnu.org>
Subject: Re: sans-serif name change
Date: Wed, 25 Jun 2008 10:00:38 -0400 [thread overview]
Message-ID: <jwviqvxk4bq.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <E1KBTIl-0006en-Nc@etlken.m17n.org> (Kenichi Handa's message of "Wed, 25 Jun 2008 20:36:39 +0900")
>> My guess is that the `-' in Sans-Serif is being treated as a separator
>> character, and causes Emacs to look for a font called Serif with the
>> foundry Sans, or something similar.
> Yes. I didn't change that behaviour for backward
> compatibility, but as face has the attribute :foundy now, it
> may be ok to break that compatibility.
> The parsing of XXX-YYY as FOUNDRY-FAMILY is now done in
> the function set-face-attribute as this:
> (if (and (eq (car args) :family)
> (stringp (cadr args))
> (string-match "\\([^-]*\\)-\\([^-]*\\)" (cadr args)))
> (let ((foundry (match-string 1 (cadr args)))
> (family (match-string 2 (cadr args))))
> (internal-set-lisp-face-attribute face :foundry
> (purecopy foundry)
> where)
> (internal-set-lisp-face-attribute face :family
> (purecopy family)
> where))
> (internal-set-lisp-face-attribute face (car args)
> (purecopy (cadr args))
> where)))
Maybe this "FOUNDRY-FAMILY" fallback code could be moved to the same
code that handles face-font-family-alternatives?
Stefan
next prev parent reply other threads:[~2008-06-25 14:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-25 1:06 sans-serif name change Miles Bader
2008-06-25 9:22 ` Andreas Schwab
2008-06-25 9:32 ` Miles Bader
2008-06-25 9:45 ` Andreas Schwab
2008-06-25 10:33 ` James Cloos
2008-06-25 13:19 ` Miles Bader
2008-06-25 13:26 ` Andreas Schwab
2008-06-25 13:35 ` Miles Bader
2008-06-25 13:54 ` Andreas Schwab
2008-06-25 10:10 ` Jason Rumney
2008-06-25 11:36 ` Kenichi Handa
2008-06-25 14:00 ` Stefan Monnier [this message]
2008-06-27 7:21 ` Kenichi Handa
2008-06-27 7:49 ` Miles Bader
2008-06-27 8:12 ` Kenichi Handa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwviqvxk4bq.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=handa@m17n.org \
--cc=jasonr@gnu.org \
--cc=miles@gnu.org \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.