From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#1058: 23.0.60; emacs --daemon should not return until socket is ready Date: Mon, 13 Oct 2008 15:07:59 -0400 Message-ID: References: <1222782234_2281@mail.internode.on.net> <200810011651.m91GpAZQ010333@mothra.ics.uci.edu> <87k5csds03.fsf@elegiac.orebokech.com> <200810012332.m91NWJ4s014658@mothra.ics.uci.edu> <874p3vediy.fsf@elegiac.orebokech.com> <200810020814.m928Ed1C016380@mothra.ics.uci.edu> <200810021726.m92HQcTQ017644@mothra.ics.uci.edu> <200810022234.m92MYgYp018688@mothra.ics.uci.edu> <200810130203.m9D23eul000572@mothra.ics.uci.edu> <200810131701.m9DH1ItS002005@mothra.ics.uci.edu> Reply-To: Stefan Monnier , 1058@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1223926241 31997 80.91.229.12 (13 Oct 2008 19:30:41 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 13 Oct 2008 19:30:41 +0000 (UTC) Cc: trentbuck@gmail.com, 1058@emacsbugs.donarmstrong.com, Romain Francoise To: Dan Nicolaescu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Oct 13 21:31:38 2008 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KpT8W-0003sn-SO for geb-bug-gnu-emacs@m.gmane.org; Mon, 13 Oct 2008 21:31:25 +0200 Original-Received: from localhost ([127.0.0.1]:34593 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KpT7P-0000uv-8N for geb-bug-gnu-emacs@m.gmane.org; Mon, 13 Oct 2008 15:30:15 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KpT7G-0000lJ-F5 for bug-gnu-emacs@gnu.org; Mon, 13 Oct 2008 15:30:06 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KpT7E-0000jN-Ug for bug-gnu-emacs@gnu.org; Mon, 13 Oct 2008 15:30:05 -0400 Original-Received: from [199.232.76.173] (port=42014 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KpT7E-0000j8-Fi for bug-gnu-emacs@gnu.org; Mon, 13 Oct 2008 15:30:04 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:34788) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KpT7D-0006a2-Sb for bug-gnu-emacs@gnu.org; Mon, 13 Oct 2008 15:30:04 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m9DJTxJ2023222; Mon, 13 Oct 2008 12:29:59 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id m9DJF2nx019755; Mon, 13 Oct 2008 12:15:02 -0700 X-Loop: don@donarmstrong.com Resent-From: Stefan Monnier Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Mon, 13 Oct 2008 19:15:02 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 1058 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 1058-submit@emacsbugs.donarmstrong.com id=B1058.122392489318525 (code B ref 1058); Mon, 13 Oct 2008 19:15:02 +0000 Original-Received: (at 1058) by emacsbugs.donarmstrong.com; 13 Oct 2008 19:08:13 +0000 Original-Received: from ironport2-out.teksavvy.com (ironport2-out.pppoe.ca [206.248.154.182]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m9DJ86BJ018519 for <1058@emacsbugs.donarmstrong.com>; Mon, 13 Oct 2008 12:08:07 -0700 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ah4FAAI580jO+IL0/2dsb2JhbACBcrtFgWyBCIIe X-IronPort-AV: E=Sophos;i="4.33,404,1220241600"; d="scan'208";a="28350040" Original-Received: from 206-248-130-244.dsl.teksavvy.com (HELO ceviche.home) ([206.248.130.244]) by ironport2-out.teksavvy.com with ESMTP; 13 Oct 2008 15:08:00 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 1115C7001C; Mon, 13 Oct 2008 15:08:00 -0400 (EDT) In-Reply-To: <200810131701.m9DH1ItS002005@mothra.ics.uci.edu> (Dan Nicolaescu's message of "Mon, 13 Oct 2008 10:01:18 -0700 (PDT)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Mon, 13 Oct 2008 15:30:05 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:21444 Archived-At: >> > -(defun server-start (&optional leave-dead) >> > +(defun server-start (&optional leave-dead server-arg) >> > "Allow this Emacs process to be a server for client processes. >> > This starts a server communications subprocess through which >> > client \"editors\" can send your editing commands to this Emacs >> > @@ -463,6 +463,8 @@ kill any existing server communications >> > (when server-process >> > ;; kill it dead! >> > (ignore-errors (delete-process server-process))) >> > + (when (stringp server-arg) >> > + (setq server-name server-arg)) >> >> Changing the global var like this is an ugly hack. > Sure, it can be moved before the call to `sever-start' > I also wanted to make that variable obsolete and make the functional > interface the preferred method. There's no need or reason to make it obsolete. You basically want to replace the last two lines above with (unless (stringp server-arg) (setq server-arg server-name)) and then pass server-arg where it's needed. > But that is a separate issue, and it's quite orthogonal to the point of > this patch. Since I'm basically not excited at the idea of adding yet more features at this point, it's good to try and make sure that any such proposal comes with the cleanest code possible, rather than with a quick fix. Stefan