From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Dan Nicolaescu <dann@ics.uci.edu>
Cc: trentbuck@gmail.com, 1058@emacsbugs.donarmstrong.com,
Romain Francoise <romain@orebokech.com>
Subject: bug#1058: 23.0.60; emacs --daemon should not return until socket is ready
Date: Mon, 13 Oct 2008 15:07:59 -0400 [thread overview]
Message-ID: <jwviqrwuxhp.fsf-monnier+emacsbugreports@gnu.org> (raw)
In-Reply-To: <200810131701.m9DH1ItS002005@mothra.ics.uci.edu> (Dan Nicolaescu's message of "Mon, 13 Oct 2008 10:01:18 -0700 (PDT)")
>> > -(defun server-start (&optional leave-dead)
>> > +(defun server-start (&optional leave-dead server-arg)
>> > "Allow this Emacs process to be a server for client processes.
>> > This starts a server communications subprocess through which
>> > client \"editors\" can send your editing commands to this Emacs
>> > @@ -463,6 +463,8 @@ kill any existing server communications
>> > (when server-process
>> > ;; kill it dead!
>> > (ignore-errors (delete-process server-process)))
>> > + (when (stringp server-arg)
>> > + (setq server-name server-arg))
>>
>> Changing the global var like this is an ugly hack.
> Sure, it can be moved before the call to `sever-start'
> I also wanted to make that variable obsolete and make the functional
> interface the preferred method.
There's no need or reason to make it obsolete. You basically want to
replace the last two lines above with
(unless (stringp server-arg)
(setq server-arg server-name))
and then pass server-arg where it's needed.
> But that is a separate issue, and it's quite orthogonal to the point of
> this patch.
Since I'm basically not excited at the idea of adding yet more features
at this point, it's good to try and make sure that any such proposal
comes with the cleanest code possible, rather than with a quick fix.
Stefan
next prev parent reply other threads:[~2008-10-13 19:07 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-30 13:43 bug#1058: 23.0.60; emacs --daemon should not return until socket is ready SRS0+wOMF+22+gmail.com=trentbuck
2008-10-01 16:51 ` Dan Nicolaescu
2008-10-01 19:39 ` Romain Francoise
2008-10-01 20:19 ` Andreas Schwab
2008-10-02 6:05 ` Romain Francoise
2008-10-01 23:32 ` Dan Nicolaescu
2008-10-02 6:07 ` Romain Francoise
2008-10-02 8:14 ` Dan Nicolaescu
2008-10-02 12:38 ` Stefan Monnier
2008-10-02 17:26 ` Dan Nicolaescu
2008-10-02 21:32 ` Stefan Monnier
2008-10-02 22:34 ` Dan Nicolaescu
2008-10-02 22:46 ` Trent W. Buck
2008-10-03 1:12 ` Stefan Monnier
2008-10-03 4:52 ` Dan Nicolaescu
2008-10-03 13:00 ` Stefan Monnier
2008-10-03 17:44 ` Dan Nicolaescu
2008-10-13 2:03 ` Dan Nicolaescu
2008-10-13 15:16 ` Stefan Monnier
2008-10-13 17:01 ` Dan Nicolaescu
2008-10-13 19:07 ` Stefan Monnier [this message]
2008-10-14 7:26 ` Dan Nicolaescu
2008-10-27 7:04 ` Dan Nicolaescu
2008-10-02 22:42 ` Trent W. Buck
2008-10-02 17:54 ` Romain Francoise
2008-10-02 18:40 ` Dan Nicolaescu
2008-10-06 20:59 ` Dan Nicolaescu
2008-10-07 14:26 ` Stefan Monnier
2008-10-07 15:31 ` Dan Nicolaescu
2008-10-07 23:13 ` Trent W. Buck
2008-10-08 2:03 ` Stefan Monnier
2008-10-08 2:25 ` Stefan Monnier
2008-10-07 18:45 ` Romain Francoise
2008-10-07 19:01 ` Dan Nicolaescu
2008-10-26 19:24 ` Dan Nicolaescu
2008-10-02 0:50 ` Trent W. Buck
2008-10-02 0:43 ` Trent W. Buck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwviqrwuxhp.fsf-monnier+emacsbugreports@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=1058@emacsbugs.donarmstrong.com \
--cc=dann@ics.uci.edu \
--cc=romain@orebokech.com \
--cc=trentbuck@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.