Re: bug in server-start

[Stefan Monnier <monnier@iro.umontreal.ca>]

>>> Exit with an error, please. And if possible, the parent process should
>>> return a nonzero exit status. (AFAICS, not calling daemon-initialized
>>> should be sufficient for this, but I haven't tested it.)
> It turns out that I should have tested this ...
>> Please, try the attached patch.
> Looks good, except for the exit status of the parent which is zero.
> The following will test for one character to be read from the pipe
> (which is sent when daemon-initialized is called):

> --- src/emacs.c
> +++ src/emacs.c
> @@ -1124,7 +1124,7 @@
>  	    }
>  	  while (retval == -1 && errno == EINTR);
 
> -	  if (retval < 0)
> +	  if (retval <= 0)
>  	    {
>  	      fprintf (stderr, "Error reading status from child\n");
>  	      exit (1);

Indeed, we should return a non-zero status, but this patch ends up with
this undesirable "Error reading status from child" message, so we want
something better.


        Stefan