all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Juri Linkov <juri@jurta.org>
Cc: Tom Tromey <tromey@redhat.com>, Dan Nicolaescu <dann@ics.uci.edu>,
	emacs-devel@gnu.org
Subject: Re: dir-locals.el take precedence over user's mode-hook changes
Date: Tue, 30 Dec 2008 12:20:58 -0500	[thread overview]
Message-ID: <jwviqp1vb39.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87wsdpp9q8.fsf@jurta.org> (Juri Linkov's message of "Wed, 24 Dec 2008 22:52:55 +0200")

> I agree with Stefan that the current order of calling a hook and
> setting local variables (either dired-local or file-local) is wrong.

Just to make things clear, I do not think the current order is
necessarily wrong.  I think either order will sometimes be right
sometimes be wrong, depending on the intention.  E.g. it's often right
for file-local settings to take precedence over "mode-local" settings
(set by mode hook).

So rather than "just" switch the order, we need to find a way for the
user to be able to cleanly specify which behavior he wants on a case by
case basis.

> `bug-reference-url-format' set in Local Variables to the string
> "http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=%s"
> (BTW, this file-local variable should be moved to .dir-locals.el)

Could you explain why you think it should be in dir-locals rather than
in the file?

> And when I try to enable `bug-reference-mode' using the following hook:
>   (add-hook 'change-log-mode-hook 'bug-reference-mode)
> it never gets enabled because `bug-reference-mode' tests whether
> a variable `bug-reference-url-format' is non-nil before enabling this mode,
> and this variable is not yet set because it gets initialized later in
> `hack-local-variables'.

Please report this bug.


        Stefan




  reply	other threads:[~2008-12-30 17:20 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-24 18:31 dir-locals.el take precedence over user's mode-hook changes Stefan Monnier
2008-12-24 19:03 ` Dan Nicolaescu
2008-12-24 20:31   ` Tom Tromey
2008-12-24 20:52     ` Juri Linkov
2008-12-30 17:20       ` Stefan Monnier [this message]
2008-12-30 23:59         ` Juri Linkov
2008-12-31  1:43           ` Stefan Monnier
2008-12-31  1:54           ` Dan Nicolaescu
2008-12-31 12:28             ` Juri Linkov
2008-12-31 16:17               ` Dan Nicolaescu
2008-12-31 17:27                 ` Stefan Monnier
2008-12-31 21:41                   ` Dan Nicolaescu
2008-12-31 23:50                     ` Chetan Pandya
2009-01-03  0:45                       ` Juri Linkov
2008-12-31 16:39           ` Richard M Stallman
2008-12-25  4:49   ` Miles Bader

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwviqp1vb39.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=dann@ics.uci.edu \
    --cc=emacs-devel@gnu.org \
    --cc=juri@jurta.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.