all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Dan Nicolaescu <dann@ics.uci.edu>
Cc: Chong Yidong <cyd@stupidchicken.com>,
	Nick Roberts <nickrob@snap.net.nz>,
	emacs-devel@gnu.org
Subject: Re: VC Development
Date: Mon, 02 Feb 2009 16:15:39 -0500	[thread overview]
Message-ID: <jwviqnsy20j.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <200902021844.n12Ii332020674@rodan.ics.uci.edu> (Dan Nicolaescu's message of "Mon, 2 Feb 2009 10:44:03 -0800 (PST)")

>> > Seeing obviously wrong stuff like this:
>> > +;; Keep existing map.
>> > +(defvar vc-dir-mouse-map
>> > +  (let ((map vc-dir-mode-map))
>> > +    (define-key map [mouse-2] 'vc-dir-find-file-other-window)
>> > +    map)
>> > +  "Local keymap for visiting a file.")
>> > I don't have time to fix it properly now, so the best thing to do is to
>> > revert it.
>> 
>> No, the best thing to do is to report it here (or on emacsbugs).

> In general, maybe.  But absolutely NOT in this particular case:
> obviously broken and clearly untested stuff 2 days before the prestest
> and I have no time to properly fix it.  And the person making the change
> has shown time and again that is not interested in anything else but
> personal attacks.  Sorry, I don't have any intention on wasting time on that.

It was a 30s fix.  Don't *ever* undo someone's change without first
reporting the problem here.


        Stefan




  reply	other threads:[~2009-02-02 21:15 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-31 23:41 VC Development Nick Roberts
2009-02-01  2:25 ` Chong Yidong
2009-02-01  6:02   ` Dan Nicolaescu
2009-02-01  8:16     ` Nick Roberts
2009-02-01 14:25       ` Chong Yidong
2009-02-01 19:47         ` Nick Roberts
2009-02-01 21:33       ` Stefan Monnier
2009-02-04  9:34         ` Nick Roberts
2009-02-04 19:31           ` Stefan Monnier
2009-02-05  6:54             ` Nick Roberts
2009-02-05 21:01               ` Stefan Monnier
2009-02-01 21:22     ` Stefan Monnier
2009-02-02 18:44       ` Dan Nicolaescu
2009-02-02 21:15         ` Stefan Monnier [this message]
2009-02-03  7:39         ` Nick Roberts
2009-02-01  2:41 ` Chong Yidong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwviqnsy20j.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=cyd@stupidchicken.com \
    --cc=dann@ics.uci.edu \
    --cc=emacs-devel@gnu.org \
    --cc=nickrob@snap.net.nz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.