From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#4381: 23.1.50; Cocoa Emacs: face background for 'region set in ns-win.el after .emacs Date: Thu, 24 Sep 2009 13:35:03 -0400 Message-ID: References: <1247DB83-08F4-4294-988D-494669656649@gmail.com> <82F117D9-CE52-4B25-98CA-0ABAAF0EC35F@gmail.com> <148ADF99-61FF-430A-BCC3-471FDAE93BB8@gmail.com> Reply-To: Stefan Monnier , 4381@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1253814464 14885 80.91.229.12 (24 Sep 2009 17:47:44 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 24 Sep 2009 17:47:44 +0000 (UTC) Cc: 4381@emacsbugs.donarmstrong.com, Erik Charlebois To: Adrian Robert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Sep 24 19:47:36 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MqsPo-00018H-AT for geb-bug-gnu-emacs@m.gmane.org; Thu, 24 Sep 2009 19:47:36 +0200 Original-Received: from localhost ([127.0.0.1]:38492 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MqsPn-0001Ro-So for geb-bug-gnu-emacs@m.gmane.org; Thu, 24 Sep 2009 13:47:35 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MqsPR-0001K9-Km for bug-gnu-emacs@gnu.org; Thu, 24 Sep 2009 13:47:13 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MqsPL-0001Iq-P7 for bug-gnu-emacs@gnu.org; Thu, 24 Sep 2009 13:47:12 -0400 Original-Received: from [199.232.76.173] (port=44897 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MqsPL-0001If-Lk for bug-gnu-emacs@gnu.org; Thu, 24 Sep 2009 13:47:07 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:58340) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MqsPL-0003zf-3O for bug-gnu-emacs@gnu.org; Thu, 24 Sep 2009 13:47:07 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8OHl4QT028295; Thu, 24 Sep 2009 10:47:05 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n8OHj4qI027944; Thu, 24 Sep 2009 10:45:04 -0700 Resent-Date: Thu, 24 Sep 2009 10:45:04 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Stefan Monnier Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs , owner@emacsbugs.donarmstrong.com 2Resent-Date: Thu, 24 Sep 2009 17:45:04 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 4381 X-Emacs-PR-Package: emacs,ns X-Emacs-PR-Keywords: Original-Received: via spool by 4381-submit@emacsbugs.donarmstrong.com id=B4381.125381370726687 (code B ref 4381); Thu, 24 Sep 2009 17:45:04 +0000 Original-Received: (at 4381) by emacsbugs.donarmstrong.com; 24 Sep 2009 17:35:07 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from pruche.dit.umontreal.ca (pruche.dit.umontreal.ca [132.204.246.22]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8OHZ49F026608 for <4381@emacsbugs.donarmstrong.com>; Thu, 24 Sep 2009 10:35:06 -0700 Original-Received: from faina.iro.umontreal.ca (faina.iro.umontreal.ca [132.204.26.177]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id n8OHZ3Ee003793; Thu, 24 Sep 2009 13:35:03 -0400 Original-Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id A608B3A122; Thu, 24 Sep 2009 13:35:03 -0400 (EDT) In-Reply-To: (Adrian Robert's message of "Thu, 24 Sep 2009 12:15:31 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV3370=0 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Resent-Date: Thu, 24 Sep 2009 13:47:12 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:31465 Archived-At: >>> --- faces.el.~1.446.~ 2009-09-05 15:33:48.000000000 -0400 >>> +++ faces.el 2009-09-23 23:06:19.000000000 -0400 >>> @@ -2281,6 +2281,8 @@ terminal type to a different value." >>> (defface region >>> '((((class color) (min-colors 88) (background dark)) >>> :background "blue3") >>> + (((class color) (min-colors 88) (background light) (type ns)) >>> + :background "ns_selection_color") >>> (((class color) (min-colors 88) (background light)) >>> :background "lightgoldenrod2") >>> (((class color) (min-colors 16) (background dark)) >> >> Could you add a comment explaining why you put (background light) in >> the specs? I guess it's because the ns_selection_color is (almost) >> always defined with the assumption that it will be used on text >> displayed on a light background., right? > Something like: > ;; Region face: under NS, use the system-defined selection color > ;; (optimized for the system-fixed white background of other apps), > ;; if background is light. Looks good, please install it, Stefan