From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Adrian Robert <adrian.b.robert@gmail.com>
Cc: 4381@emacsbugs.donarmstrong.com,
Erik Charlebois <erikcharlebois@gmail.com>
Subject: bug#4381: 23.1.50; Cocoa Emacs: face background for 'region set in ns-win.el after .emacs
Date: Thu, 24 Sep 2009 13:35:03 -0400 [thread overview]
Message-ID: <jwviqf8nt52.fsf-monnier+emacsbugreports@gnu.org> (raw)
In-Reply-To: <E247C5ED-983B-4507-A454-C68976E3EDD6@gmail.com> (Adrian Robert's message of "Thu, 24 Sep 2009 12:15:31 -0400")
>>> --- faces.el.~1.446.~ 2009-09-05 15:33:48.000000000 -0400
>>> +++ faces.el 2009-09-23 23:06:19.000000000 -0400
>>> @@ -2281,6 +2281,8 @@ terminal type to a different value."
>>> (defface region
>>> '((((class color) (min-colors 88) (background dark))
>>> :background "blue3")
>>> + (((class color) (min-colors 88) (background light) (type ns))
>>> + :background "ns_selection_color")
>>> (((class color) (min-colors 88) (background light))
>>> :background "lightgoldenrod2")
>>> (((class color) (min-colors 16) (background dark))
>>
>> Could you add a comment explaining why you put (background light) in
>> the specs? I guess it's because the ns_selection_color is (almost)
>> always defined with the assumption that it will be used on text
>> displayed on a light background., right?
> Something like:
> ;; Region face: under NS, use the system-defined selection color
> ;; (optimized for the system-fixed white background of other apps),
> ;; if background is light.
Looks good, please install it,
Stefan
next prev parent reply other threads:[~2009-09-24 17:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-18 23:57 bug#4381: 23.1.50; Cocoa Emacs: face background for 'region set in ns-win.el after .emacs Adrian Robert
2009-09-19 4:19 ` Erik Charlebois
2009-09-20 13:37 ` Stefan Monnier
2009-09-22 23:19 ` Adrian Robert
2009-09-23 22:44 ` Stefan Monnier
2009-09-24 3:19 ` Adrian Robert
2009-09-24 15:14 ` Stefan Monnier
2009-09-24 16:15 ` Adrian Robert
2009-09-24 17:35 ` Stefan Monnier [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-09-09 7:23 Erik Charlebois
2009-09-10 6:27 ` Glenn Morris
2009-09-13 21:56 ` Erik Charlebois
2009-09-14 1:09 ` Glenn Morris
2009-09-14 6:07 ` Erik Charlebois
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwviqf8nt52.fsf-monnier+emacsbugreports@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=4381@emacsbugs.donarmstrong.com \
--cc=adrian.b.robert@gmail.com \
--cc=erikcharlebois@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.