From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Chong Yidong <cyd@stupidchicken.com>
Cc: emacs-devel@gnu.org
Subject: Re: with-current-buffer "cleanup" bug
Date: Sat, 14 Nov 2009 13:07:29 -0500 [thread overview]
Message-ID: <jwviqdddlt1.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87d43lm7ev.fsf@stupidchicken.com> (Chong Yidong's message of "Sat, 14 Nov 2009 10:51:20 -0500")
> If you're wholesale changing `save-excursion + set-buffer' to
> `with-current-buffer', this is wrong.
The change may be wrong, but the original code is wrong too. Which is
why I'm happily applying the change: when it uncovers a bug, the right
fix is almost always to use some other code because the problem can
appear even with the original code.
> The `with-current-buffer' macro
> does not save point (or mark), so this can lead to code behavior change.
> You need to fix this, or we're likely see a long slow trickle of related
> bugs in the coming weeks and months.
Yes, I'm waiting for those bugs indeed,
Stefan
next prev parent reply other threads:[~2009-11-14 18:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-14 15:51 with-current-buffer "cleanup" bug Chong Yidong
2009-11-14 18:07 ` Stefan Monnier [this message]
2009-11-14 22:27 ` Chong Yidong
2009-11-15 4:48 ` Stefan Monnier
2009-11-15 15:26 ` Chong Yidong
2009-11-15 5:13 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwviqdddlt1.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=cyd@stupidchicken.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.