From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel,gmane.emacs.gnus.general Subject: Re: mm-with-unibyte-current-buffer Date: Mon, 10 May 2010 21:02:18 -0400 Message-ID: References: <83y6frptd7.fsf@gnu.org> <83tyqfppab.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1273539754 17814 80.91.229.12 (11 May 2010 01:02:34 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 11 May 2010 01:02:34 +0000 (UTC) Cc: yamaoka@jpl.org, ding@gnus.org, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 11 03:02:32 2010 connect(): No such file or directory Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OBdrg-0000WP-Sj for ged-emacs-devel@m.gmane.org; Tue, 11 May 2010 03:02:29 +0200 Original-Received: from localhost ([127.0.0.1]:50273 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OBdrg-0007y0-CG for ged-emacs-devel@m.gmane.org; Mon, 10 May 2010 21:02:28 -0400 Original-Received: from [140.186.70.92] (port=46166 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OBdra-0007xc-Qw for emacs-devel@gnu.org; Mon, 10 May 2010 21:02:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OBdrZ-00047b-NB for emacs-devel@gnu.org; Mon, 10 May 2010 21:02:22 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.183]:55437 helo=ironport2-out.pppoe.ca) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OBdrX-00046p-DI; Mon, 10 May 2010 21:02:19 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AvsEAN5J6EtLd+Zs/2dsb2JhbACeI3K7CIUUBIwy X-IronPort-AV: E=Sophos;i="4.53,203,1272859200"; d="scan'208";a="63867475" Original-Received: from 75-119-230-108.dsl.teksavvy.com (HELO pastel.home) ([75.119.230.108]) by ironport2-out.pppoe.ca with ESMTP; 10 May 2010 21:02:18 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 81BF180B1; Mon, 10 May 2010 21:02:18 -0400 (EDT) In-Reply-To: <83tyqfppab.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 10 May 2010 21:47:24 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:124685 gmane.emacs.gnus.general:69675 Archived-At: >> > Binding the value of enable-multibyte-characters may be a no-no, but >> > _testing_ its value is still possible. So I see no reason to >> > set-buffer-multibyte unconditionally, because you may already be in a >> > unibyte buffer. >> But calling set-buffer-multibyte with the current value is harmless (it >> checks a returns right away if there's nothing to do; this check might >> even be faster than doing it in Elisp). > That's true, but the unconditional call `(set-buffer-multibyte t)' at > the end of the macro is _not_ harmless, if the buffer was originally a > unibyte one. Right, this is "on purpose", IIUC (I don't actually understand what this macro intends to do, which is why I haven't touched it other than to add increasingly scary warnings to it). Stefan