all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: "Jordi Gutiérrez Hermoso" <jordigh@gmail.com>
Cc: Daniel Colascione <daniel@censorshipresearch.org>,
	Emacs development discussions <emacs-devel@gnu.org>
Subject: Re: [PATCH] let octave-mode understand single-quoted strings
Date: Wed, 01 Sep 2010 08:46:58 +0200	[thread overview]
Message-ID: <jwviq2qc6i3.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <AANLkTimhQg1LD-EVW9S45KiC9k6JXpSw_OBdUw=JyFYE@mail.gmail.com> ("Jordi Gutiérrez Hermoso"'s message of "Tue, 31 Aug 2010 16:15:39 -0500")

>> I'm not familiar with Octave, so your code might be more correct in
>> some cases, OTOH my code handles multi-line strings. Do you think we
>> should try and get the best of both worlds, or should we replace my
>> code with yours, or should we just stick with my code?

> Daniel's code is correct in several cases I tried, so I would
> recommend it.  I don't know what you may have done with multiline
> strings, but they seem to work just as well.

IIUC Daniel's code, his multiline strings will only work if font-lock
happens to fontify the whole string at a time.  If it only needs to
update a single line (e.g. when you edit the first or last line of
a multiline single-quoted string), it will forget that it's a string (I
think it may even lead to nasty misfontifications where the rest of the
text gets fontified as a string).

> Of course it would be nice if both features worked.

That's definitely doable.  Tho if multiline strings are very rare and
are discouraged/deprecated, it might not be worth the trouble.

> Octave mode still requires a lot of work in other directions. Octave
> syntax has been enriched somewhat since the mode was first written.
> With time I may be able to provide these necessary patches myself.

Please check the new code in Emacs's trunk (uses the new SMIE package to
do the navigation and indentation) and report any missing feature (with
patch if you can: hopefully the new code makes it easier).


        Stefan



  reply	other threads:[~2010-09-01  6:46 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-30 21:19 [PATCH] let octave-mode understand single-quoted strings Daniel Colascione
2010-08-31 12:32 ` Stefan Monnier
2010-08-31 21:15   ` Jordi Gutiérrez Hermoso
2010-09-01  6:46     ` Stefan Monnier [this message]
2010-09-02 14:07       ` Jordi Gutiérrez Hermoso
2010-09-02 16:24         ` Stefan Monnier
2010-09-02 23:46           ` Jordi Gutiérrez Hermoso
2010-09-03 10:48             ` Stefan Monnier
2010-10-05  8:28               ` John W. Eaton
2010-10-05 23:57                 ` Eric M. Ludlam
2010-10-07  8:41                   ` Stefan Monnier
2011-10-04 15:13                     ` Jordi Gutiérrez Hermoso
2011-10-04 17:40                       ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwviq2qc6i3.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=daniel@censorshipresearch.org \
    --cc=emacs-devel@gnu.org \
    --cc=jordigh@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.