From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Kenichi Handa <handa@m17n.org>
Cc: miles@gnu.org, emacs-devel@gnu.org
Subject: Re: bug#7234: 24.0.50; strange message after text-scale-adjust
Date: Tue, 19 Oct 2010 12:26:55 -0400 [thread overview]
Message-ID: <jwviq0ym9ph.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <tl7wrpfggqp.fsf@m17n.org> (Kenichi Handa's message of "Tue, 19 Oct 2010 09:37:18 +0900")
>> > It would be better that read-event call in
>> > text-scale-adjust has some prompt:
>> > e.g. (read-event "+,-,0 for further adjustment: ")
>> Agreed.
> Shall I install that change, or do you have a better prompt
> string, or should we wait for your alternative
> implementation?
Go ahead with your change. It's not directly related to my alternative
implementation anyway and that implementation is still work in progress.
>> > For non-interactive use, you should probably also be using
>> > `text-scale-set' or `text-scale-increase' instead.
>> BTW, I've been playing around with an alternative implementation for
>> such things. The reason is that the use of
>> read-event/read-char/read-key has surprising side-effects: in those
>> cases I'm concerned with, the user expects that the command is already
>> finished and the behavior is somewhat consistent with that expectation,
>> but not completely: indeed typing "any" key sequence (except for a few
>> special ones) runs the usual corresponding command, but OTOH
>> post-command-hook and friends aren't run when expected.
> I think the situation is similar to isearch. How does
> isearch solve it?
isearch uses an overlay map (overriding-terminal-local-map) rather than
read-key/event/char.
> With that, how to show the prompt?
You'd do it with `message'.
Stefan
next prev parent reply other threads:[~2010-10-19 16:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-18 4:09 bug#7234: 24.0.50; strange message after text-scale-adjust Kenichi Handa
2010-10-18 7:16 ` Eli Zaretskii
2010-10-18 10:55 ` Kenichi Handa
[not found] ` <mailman.0.1287400359.30531.bug-gnu-emacs@gnu.org>
2010-10-18 12:30 ` Miles Bader
2010-10-18 14:17 ` Stefan Monnier
2010-10-19 0:37 ` Kenichi Handa
2010-10-19 16:26 ` Stefan Monnier [this message]
2010-10-20 2:00 ` Kenichi Handa
2010-10-20 16:07 ` Stefan Monnier
2010-10-21 1:21 ` Kenichi Handa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwviq0ym9ph.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=handa@m17n.org \
--cc=miles@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.