all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs18@gmail.com
Cc: 8998@debbugs.gnu.org
Subject: bug#8998: further analysis of the problem
Date: Tue, 05 Jul 2011 14:28:43 -0400	[thread overview]
Message-ID: <jwviprg37mr.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <qtmliwdcrnb.fsf@gmail.com> (emacs's message of "Mon, 04 Jul 2011 20:50:32 -0700")

> Why is `lisp-interaction-mode-abbrev-table' its own parent?

I've installed the patch below which I believe fixes the problem.
Can you confirm that it fixes the problem for you?


        Stefan


=== modified file 'lisp/emacs-lisp/derived.el'
--- lisp/emacs-lisp/derived.el	2011-07-01 16:41:02 +0000
+++ lisp/emacs-lisp/derived.el	2011-07-05 18:23:08 +0000
@@ -255,7 +255,10 @@
 				   (not (eq parent (standard-syntax-table))))
 			(set-char-table-parent ,syntax (syntax-table)))))
                 ,(when declare-abbrev
-                   `(unless (abbrev-table-get ,abbrev :parents)
+                   `(unless (or (abbrev-table-get ,abbrev :parents)
+                                ;; This can happen if the major mode defines
+                                ;; the abbrev-table to be its parent's.
+                                (eq ,abbrev local-abbrev-table))
                       (abbrev-table-put ,abbrev :parents
                                         (list local-abbrev-table))))))
 	  (use-local-map ,map)

=== modified file 'lisp/emacs-lisp/lisp-mode.el'
--- lisp/emacs-lisp/lisp-mode.el	2011-06-28 12:09:43 +0000
+++ lisp/emacs-lisp/lisp-mode.el	2011-07-05 16:14:45 +0000
@@ -525,7 +525,6 @@
   "Keymap for Lisp Interaction mode.
 All commands in `lisp-mode-shared-map' are inherited by this map.")
 
-(defvar lisp-interaction-mode-abbrev-table lisp-mode-abbrev-table)
 (define-derived-mode lisp-interaction-mode emacs-lisp-mode "Lisp Interaction"
   "Major mode for typing and evaluating Lisp forms.
 Like Lisp mode except that \\[eval-print-last-sexp] evals the Lisp expression






  reply	other threads:[~2011-07-05 18:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-05  0:47 bug#8998: 24.0.50; expand-abbrev goes into infinite loop Richard Kim
2011-07-05  2:14 ` bug#8998: culprit found emacs18
2011-07-05  3:50 ` bug#8998: further analysis of the problem emacs18
2011-07-05 18:28   ` Stefan Monnier [this message]
     [not found]     ` <qtm39ikiij3.fsf@gmail.com>
2011-07-06  1:09       ` Stefan Monnier
2011-07-05 15:32 ` bug#8998: #8999 seems to be duplicate of #8998 Richard Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwviprg37mr.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=8998@debbugs.gnu.org \
    --cc=emacs18@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.