From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#9311: 23.3.50; Can't load some byte-compiled files on Windows Date: Tue, 30 Aug 2011 12:31:05 -0400 Message-ID: References: <20110817002457.0B68A1E0043@msa101.auone-net.jp> <83zkj8s9hh.fsf@gnu.org> <87zkirnhbv.fsf@gmx.de> <87r542or81.fsf@gmx.de> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1314721925 29623 80.91.229.12 (30 Aug 2011 16:32:05 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 30 Aug 2011 16:32:05 +0000 (UTC) Cc: Kazuhiro Ito , 9311@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Aug 30 18:32:00 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QyREG-0006x9-CF for geb-bug-gnu-emacs@m.gmane.org; Tue, 30 Aug 2011 18:32:00 +0200 Original-Received: from localhost ([::1]:33082 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QyREF-0007mN-Q5 for geb-bug-gnu-emacs@m.gmane.org; Tue, 30 Aug 2011 12:31:59 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:41501) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QyREB-0007m5-VI for bug-gnu-emacs@gnu.org; Tue, 30 Aug 2011 12:31:56 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QyREA-00042f-P7 for bug-gnu-emacs@gnu.org; Tue, 30 Aug 2011 12:31:55 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:47722) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QyREA-00042a-NZ for bug-gnu-emacs@gnu.org; Tue, 30 Aug 2011 12:31:54 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1QyRHC-0002ZH-8C; Tue, 30 Aug 2011 12:35:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 30 Aug 2011 16:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9311 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 9311-submit@debbugs.gnu.org id=B9311.13147220589813 (code B ref 9311); Tue, 30 Aug 2011 16:35:02 +0000 Original-Received: (at 9311) by debbugs.gnu.org; 30 Aug 2011 16:34:18 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QyRGU-0002YD-9c for submit@debbugs.gnu.org; Tue, 30 Aug 2011 12:34:18 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QyRGR-0002Y5-B7 for 9311@debbugs.gnu.org; Tue, 30 Aug 2011 12:34:16 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EAGYPXU64rwMJ/2dsb2JhbAA5CagieIFAAQEEAVYjBQsLNBIUGA0kiAW5VIMpgyQEoAiEPQ X-IronPort-AV: E=Sophos;i="4.68,303,1312171200"; d="scan'208";a="133549248" Original-Received: from 184-175-3-9.dsl.teksavvy.com (HELO ceviche.home) ([184.175.3.9]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 30 Aug 2011 12:31:05 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 2F59566108; Tue, 30 Aug 2011 12:31:05 -0400 (EDT) In-Reply-To: <87r542or81.fsf@gmx.de> (Michael Albinus's message of "Tue, 30 Aug 2011 17:26:38 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Tue, 30 Aug 2011 12:35:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:50443 Archived-At: > In order to let Tramp continue its work, we have accepted remote file > names with a leading volume letter, which are removed by Tramp > then. This worked almost OK, except such cases as discussed in the > current (and earlier) bug reports. > Eli did suggest to remove this hack from Tramp, and to see during the > test where the unexpected volume letter prefix happens. Problems shall > be fixed there. Sounds good. We should fix it right instead of using the current workaround. > @@ -861,13 +861,8 @@ > Also see `tramp-file-name-structure'.") > ;;;###autoload > -(defconst tramp-root-regexp > - (if (memq system-type '(cygwin windows-nt)) > - "\\`\\([a-zA-Z]:\\)?/" > - "\\`/") > - "Beginning of an incomplete Tramp file name. > -Usually, it is just \"\\\\`/\". On W32 systems, there might be a > -volume letter, which will be removed by `tramp-drop-volume-letter'.") > +(defconst tramp-root-regexp "\\`/" > + "Beginning of an incomplete Tramp file name.") Looks OK. > @@ -1503,7 +1498,7 @@ > but the remote system is Unix, this introduces a superfluous drive > letter into the file name. This function removes it." > (save-match-data > - (if (string-match tramp-root-regexp name) > + (if (string-match "\\`[a-zA-Z]:/" name) > (replace-match "/" nil t name) > name))) Shouldn't tramp-drop-volume-letter disappear completely? Stefan PS: by the way, here's a tiny informational patch about common subexpression elimination and about how to silence the compiler without a hack. === modified file 'lisp/net/tramp.el' --- lisp/net/tramp.el 2011-07-24 14:57:37 +0000 +++ lisp/net/tramp.el 2011-08-30 16:27:59 +0000 @@ -871,9 +871,8 @@ ;;;###autoload (defconst tramp-completion-file-name-regexp-unified - (if (memq system-type '(cygwin windows-nt)) - (concat tramp-root-regexp "[^/]\\{2,\\}\\'") - (concat tramp-root-regexp "[^/]*\\'")) + (concat tramp-root-regexp (if (memq system-type '(cygwin windows-nt)) + "[^/]\\{2,\\}\\'" "[^/]*\\'")) "Value for `tramp-completion-file-name-regexp' for unified remoting. GNU Emacs uses a unified filename syntax for Tramp and Ange-FTP. See `tramp-file-name-structure' for more explanations. @@ -1494,9 +1493,9 @@ (tramp-compat-font-lock-add-keywords 'emacs-lisp-mode '("\\")) -(eval-and-compile ;; Silence compiler. +(defalias 'tramp-drop-volume-letter (if (memq system-type '(cygwin windows-nt)) - (defun tramp-drop-volume-letter (name) + (lambda (name) "Cut off unnecessary drive letter from file NAME. The functions `tramp-*-handle-expand-file-name' call `expand-file-name' locally on a remote file name. When the local system is a W32 system @@ -1506,8 +1505,7 @@ (if (string-match tramp-root-regexp name) (replace-match "/" nil t name) name))) - - (defalias 'tramp-drop-volume-letter 'identity))) + #'identity)) ;;; Config Manipulation Functions: