all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: jidanni@jidanni.org
Cc: 10168@debbugs.gnu.org
Subject: bug#10168: "Complete, but not unique" wrong
Date: Thu, 01 Dec 2011 14:37:29 -0500	[thread overview]
Message-ID: <jwvipm0axw2.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87k46hx3hy.fsf@jidanni.org>

> ESC x m a n RET d l o TAB
> gives
> Manual entry: dlo [Complete, but not unique]

> Possible completions are:
> dlocate(1)
> dlopen(3)

> So we see "[Complete, but not unique]" is wrong here, as it is not complete.

Indeed.  I've installed the patch below which should fix those problems.


        Stefan


--- lisp/man.el	2011-11-27 04:43:11 +0000
+++ lisp/man.el	2011-12-01 19:33:36 +0000
@@ -754,8 +754,10 @@
 
 (defun Man-completion-table (string pred action)
   (cond
-   ((eq action 'lambda)
-    (not (string-match "([^)]*\\'" string)))
+   ;; This ends up returning t for pretty much any string, and hence leads to
+   ;; spurious "complete but not unique" messages.  And since `man' doesn't
+   ;; require-match anyway, there's not point being clever.
+   ;;((eq action 'lambda) (not (string-match "([^)]*\\'" string)))
    ((equal string "-k")
     ;; Let SPC (minibuffer-complete-word) insert the space.
     (complete-with-action action '("-k ") string pred))






  reply	other threads:[~2011-12-01 19:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-30 11:18 bug#10168: "Complete, but not unique" wrong jidanni
2011-12-01 19:37 ` Stefan Monnier [this message]
2011-12-01 22:16   ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvipm0axw2.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=10168@debbugs.gnu.org \
    --cc=jidanni@jidanni.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.