From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Dani Moncayo <dmoncayo@gmail.com>
Cc: 10963@debbugs.gnu.org
Subject: bug#10963: 24.0.94; `dabbrev-completion' and `completion-cycle-threshold'
Date: Mon, 12 Mar 2012 16:21:21 -0400 [thread overview]
Message-ID: <jwvipi9in9q.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <jwv399dlsoy.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Mon, 12 Mar 2012 12:00:58 -0400")
>> It mostly works, but there is one detail that seems to need a fix:
>> Consider this scenario:
>> 1. M-: (setq completion-cycle-threshold 4) RET
>> 2. foo1 RET foo2 RET foo3 RET foo
>> Now, repeated `C-M-/' commands cycle like this:
>> foo3/foo1/foo2
>> but repeated `M-/' commands cycle like this:
>> foo3/foo2/foo1
>> I think that the cycling order should be equal in both cases, and IMO
>> the right order is the one followed by `M-/' (ISTR that I've read
>> something about this in the manual, but right now I can't find the
>> place).
> That will require more changes: the current cycling order of C-M-/ is
> completely different from the one of M-/ because the completion table
> used is an obarray (a sort of hash-table), so dabbrev's ordering is
> completely lost, and after that the completion code uses its default
> sorting (which gives preference to shorter completions, which in this
> case makes no difference). So we'll need to stop using an obarray, and
> to pass an ad-hoc sorting function to the completion code.
OK, I think it's fixed now, can you confirm?
Stefan
next prev parent reply other threads:[~2012-03-12 20:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-06 22:18 bug#10963: 24.0.94; `dabbrev-completion' and `completion-cycle-threshold' Dani Moncayo
2012-03-12 13:09 ` Stefan Monnier
2012-03-12 13:41 ` Dani Moncayo
2012-03-12 16:00 ` Stefan Monnier
2012-03-12 20:21 ` Stefan Monnier [this message]
2012-03-12 20:30 ` Dani Moncayo
2012-03-13 12:43 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvipi9in9q.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=10963@debbugs.gnu.org \
--cc=dmoncayo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.