From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#13078: [PATCH] configure.ac: Cygwin build breaks when path to pkg-tool contains spaces Date: Wed, 05 Dec 2012 00:01:30 -0500 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1354683728 27762 80.91.229.3 (5 Dec 2012 05:02:08 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 5 Dec 2012 05:02:08 +0000 (UTC) Cc: Josh , 13078@debbugs.gnu.org To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Dec 05 06:02:20 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Tg77d-0000ez-8z for geb-bug-gnu-emacs@m.gmane.org; Wed, 05 Dec 2012 06:02:13 +0100 Original-Received: from localhost ([::1]:50190 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tg77R-0003h9-Bg for geb-bug-gnu-emacs@m.gmane.org; Wed, 05 Dec 2012 00:02:01 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:45949) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tg77N-0003h2-VB for bug-gnu-emacs@gnu.org; Wed, 05 Dec 2012 00:01:58 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tg77M-0001wy-Rx for bug-gnu-emacs@gnu.org; Wed, 05 Dec 2012 00:01:57 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:43731) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tg77M-0001wu-Ol for bug-gnu-emacs@gnu.org; Wed, 05 Dec 2012 00:01:56 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1Tg77R-00005T-SW for bug-gnu-emacs@gnu.org; Wed, 05 Dec 2012 00:02:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 Dec 2012 05:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13078 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 13078-submit@debbugs.gnu.org id=B13078.1354683698305 (code B ref 13078); Wed, 05 Dec 2012 05:02:01 +0000 Original-Received: (at 13078) by debbugs.gnu.org; 5 Dec 2012 05:01:38 +0000 Original-Received: from localhost ([127.0.0.1]:53982 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tg774-00004s-0J for submit@debbugs.gnu.org; Wed, 05 Dec 2012 00:01:38 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:59094) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tg772-0008WS-PO for 13078@debbugs.gnu.org; Wed, 05 Dec 2012 00:01:37 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EAG6Zu09soXOY/2dsb2JhbABEtBGBCIIWAQVWIxALDiYSFBgNJIghugmQRAOIQppxgViDBw X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="209105135" Original-Received: from 108-161-115-152.dsl.teksavvy.com (HELO pastel.home) ([108.161.115.152]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 05 Dec 2012 00:01:30 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 7AF8158C73; Wed, 5 Dec 2012 00:01:30 -0500 (EST) In-Reply-To: (Glenn Morris's message of "Tue, 04 Dec 2012 23:40:42 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:67951 Archived-At: >>>> - if $PKG_CONFIG --atleast-pkgconfig-version $PKG_CONFIG_MIN_VERSION; then >>>> + if "$PKG_CONFIG" --atleast-pkgconfig-version $PKG_CONFIG_MIN_VERSION; then >> I'd expect $PKG_CONFIG_MIN_VERSION to need quoting as well. > It's a variable that we define ourselves rather than something we get > from the environment, and we know it doesn't contain spaces. I tend to just put "..." everywhere except in those rare cases where I know I want the expansion to be split at spaces. This way I don't need to worry about whether or not this is fully under my control and whether I'm really sure it won't ever have a space in it. Served me well so far, Stefan