From: Stefan Monnier <monnier@iro.umontreal.ca>
To: martin rudalics <rudalics@gmx.at>
Cc: 13225@debbugs.gnu.org
Subject: bug#13225: 24.3.50; Non-selected window has not mode-line-inactive face
Date: Thu, 20 Dec 2012 09:03:01 -0500 [thread overview]
Message-ID: <jwvip7wsuol.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <50D2E16B.70804@gmx.at> (martin rudalics's message of "Thu, 20 Dec 2012 10:59:07 +0100")
>> Of course, when we drop frame-local variables this problem
>> will disappear.
>> Maybe we should live with the "selected_frame->selected_window !=
>> selected_window" problem until we get rid of frame-local vars.
> I completely fail to understand how frame-local variables are related to
> the problem at hand :-(
Here's the connection: in order for the redisplay code to use the proper
value of (frame-local) variables, it needs to `select-frame' on the
frame being redisplayed. Since selected-frame and selected-window
should be kept in sync, this means changing the selected-window as well,
hence the bug where each frame's selected_window is drawn as if it were
the global selected-window (the cursor seems to be unaffected, probably
because drawing the cursor is handled specially, so I suspect this
cursor code does not obey frame-local variables).
Actually, now that I think about it, maybe the right fix is to remove
this ensure_selected_frame. It would be one more step towards removing
frame-local variables (just like we already disallowed variables that
are both buffer-local and frame-local), but still without removing them
altogether. After all, I don't think that the existing uses of
frame-local vars affect the redisplay.
I've just made this change.
Stefan
next prev parent reply other threads:[~2012-12-20 14:03 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-19 8:12 bug#13225: 24.3.50; Non-selected window has not mode-line-inactive face martin rudalics
2012-12-19 16:07 ` Eli Zaretskii
2012-12-19 18:30 ` Stefan Monnier
2012-12-19 19:16 ` Drew Adams
2012-12-19 19:28 ` Drew Adams
2012-12-19 20:07 ` Stefan Monnier
2012-12-19 20:56 ` Drew Adams
2012-12-20 0:52 ` Stefan Monnier
2012-12-19 21:36 ` Eli Zaretskii
2012-12-20 2:08 ` Stefan Monnier
2012-12-20 9:59 ` martin rudalics
2012-12-20 14:03 ` Stefan Monnier [this message]
2012-12-20 16:28 ` Eli Zaretskii
2012-12-20 17:24 ` martin rudalics
2012-12-20 17:37 ` Eli Zaretskii
2012-12-21 9:15 ` martin rudalics
2012-12-21 9:35 ` Eli Zaretskii
2012-12-21 14:24 ` martin rudalics
2012-12-21 14:43 ` Eli Zaretskii
2012-12-20 17:25 ` martin rudalics
2012-12-20 18:07 ` Stefan Monnier
2012-12-21 9:16 ` martin rudalics
2012-12-22 15:52 ` Stefan Monnier
2012-12-22 16:05 ` martin rudalics
2012-12-22 16:56 ` Stefan Monnier
2012-12-22 17:42 ` martin rudalics
2012-12-23 13:41 ` Stefan Monnier
2012-12-23 14:03 ` martin rudalics
2012-12-23 15:40 ` Stefan Monnier
2012-12-20 9:59 ` martin rudalics
2012-12-20 17:09 ` Eli Zaretskii
2012-12-20 17:24 ` martin rudalics
2013-01-04 8:28 ` Glenn Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvip7wsuol.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=13225@debbugs.gnu.org \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.