bug#15594: 24.3; Indentation of method arguments without parentheses in ruby-mode is broken

bug#15594: 24.3; Indentation of method arguments without parentheses in ruby-mode is broken

[Bozhidar Batsov]

[-- Attachment #1: Type: text/plain, Size: 495 bytes --]

In Ruby one can invoke methods with or without parentheses:

some_method(arg1, arg2)
some_method arg1, arg2

ruby-mode currently does not handle properly the indentation of calls without parentheses that span several lines:

# indented properly in 24.3
some_method(arg1,
                     arg2)

# not indented at all in 24.3
some_method arg1,
arg2

Ideally the second code example would be indented by ruby-mode like this:

some_method arg1,
                     arg2

-- 
Cheers,
Bozhidar


[-- Attachment #2: Type: text/html, Size: 1618 bytes --]

bug#15594: 24.3; Indentation of method arguments without parentheses in ruby-mode is broken

[Stefan Monnier]

> In Ruby one can invoke methods with or without parentheses:
> some_method(arg1, arg2)
> some_method arg1, arg2

Interesting.  How is the following parsed, then:

   some_method arg1, other_method arg2, arg3, arg4


-- Stefan

bug#15594: 24.3; Indentation of method arguments without parentheses in ruby-mode is broken

[Bozhidar Batsov]

[-- Attachment #1: Type: text/plain, Size: 949 bytes --]

On Saturday, October 12, 2013 at 5:37 PM, Stefan Monnier wrote:
> > In Ruby one can invoke methods with or without parentheses:
> > some_method(arg1, arg2)
> > some_method arg1, arg2
> > 
> 
> 
> Interesting. How is the following parsed, then:
> 
> some_method arg1, other_method arg2, arg3, arg4
There are some limitations, of course. Ambiguous cases generally result in parsing errors:

Parser::CurrentRuby.parse('some_method arg1, other_method arg2, arg3, arg4')
(string):1:32: error: unexpected token tIDENTIFIER
some_method arg1, other_method arg2, arg3, arg4
                                                  ^^^^
Parser::SyntaxError: unexpected token tIDENTIFIER 

If we remove arg1, however, there is no ambiguity:

[21] pry(main)> Parser::CurrentRuby.parse('some_method other_method arg2, arg3, arg4')
=> (send nil :some_method
  (send nil :other_method
    (send nil :arg2)
    (send nil :arg3)
    (send nil :arg4)))

> 
> 
> -- Stefan 


[-- Attachment #2: Type: text/html, Size: 2162 bytes --]

bug#15594: 24.3; Indentation of method arguments without parentheses in ruby-mode is broken

[Stefan Monnier]

>> > In Ruby one can invoke methods with or without parentheses:
>> > some_method(arg1, arg2)
>> > some_method arg1, arg2

I just added some support for it, thank you,


        Stefan