From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Juri Linkov <juri@jurta.org>
Cc: 16438@debbugs.gnu.org
Subject: bug#16438: 24.3.50; `C-x TAB right right' fails with error (mark-inactive)
Date: Thu, 16 Jan 2014 09:00:41 -0500 [thread overview]
Message-ID: <jwviotkqbqp.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <87fvopcfdn.fsf@mail.jurta.org> (Juri Linkov's message of "Thu, 16 Jan 2014 09:53:12 +0200")
>>> I fixed this by using (eq (cadr overriding-terminal-local-map) indent-rigidly-map)
>> That's hideous, tho :-(
> I borrowed this condition from
> (not (eq map (cadr overriding-terminal-local-map)))
I know. But it has problems:
- if there's a nested use of set-transient-map (e.g. C-u), your code will
deactivate the mark even tho we're not finished with C-x TAB.
- it relies on internal details of implementation of set-transient-map.
- now C-x TAB does not deactivate the mark any more :-(
> Maybe it should be refactored to a separate predicate function.
Could be, tho the two tests need to be different.
Another option is to move the deactivation into the exit condition.
Yet another option is to change C-x TAB so that it uses (mark t) when
called repeatedly.
I'm not sure exactly how the deactivation should behave, tho:
- The current behavior seems wrong: C-x TAB does use the region, so it
should "consume it", so C-x TAB right right right up should end with
a deactivated region.
- But should the region be highlighted *during* C-x TAB? If yes, then
we have a conflict with the previous point, since just before hitting
`up' the region would still need to be highlighted, so it'd be counter
intuitive to deactivate the region right between when the user hits
`up' and when we run the corresponding `previous-line' command.
So I think that the region should *not* be highlighted during C-x TAB.
Which implies using (mark t).
Stefan
next prev parent reply other threads:[~2014-01-16 14:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-14 8:14 bug#16438: 24.3.50; `C-x TAB right right' fails with error (mark-inactive) Juri Linkov
2014-01-15 8:23 ` Juri Linkov
2014-01-15 15:31 ` Stefan Monnier
2014-01-16 7:53 ` Juri Linkov
2014-01-16 14:00 ` Stefan Monnier [this message]
2014-01-17 8:08 ` Juri Linkov
2014-01-17 14:45 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwviotkqbqp.fsf-monnier+emacsbugs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=16438@debbugs.gnu.org \
--cc=juri@jurta.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.