all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: 16604@debbugs.gnu.org
Subject: bug#16604: 24.3.50; False negatives in lisp-completion-at-point
Date: Sun, 02 Feb 2014 22:48:32 -0500	[thread overview]
Message-ID: <jwvioswsvto.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <jwvbnypt0ww.fsf-monnier+emacsbugs@gnu.org> (Stefan Monnier's message of "Sun, 02 Feb 2014 21:03:19 -0500")

>> So maybe "merge" is indeed a better default than "in-turn".
> I guess it means it might be worth trying to fix it for 24.4.
> But your completion-table-merge needs to be improved: the list passed to
> the outer `try-completion' needs to only hold strings, whereas the inner
> `try-completion's can return nil or t.

Also, the outer try-completion could end up returning t if one of the
inner ones returns the string we're trying to complete.
We might be better off always going through "(apply #'append (mapcar
#'all-completions ...))", e.g. via completion-table-dynamic.

Also, we should try and check that the sub-tables all have "trivial"
boundaries, and no quoting.


        Stefan





  reply	other threads:[~2014-02-03  3:48 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-31  4:46 bug#16604: 24.3.50; False negatives in lisp-completion-at-point Dmitry Gutov
2014-01-31 14:34 ` Stefan Monnier
2014-01-31 14:37   ` Dmitry Gutov
2014-01-31 15:05   ` Thierry Volpiatto
2014-02-02  1:52   ` Dmitry Gutov
2014-02-02  2:39     ` Stefan Monnier
2014-02-02  3:00       ` Dmitry Gutov
2014-02-02 14:12         ` Stefan Monnier
2014-02-02 18:24           ` Stefan Monnier
2014-02-03  2:03             ` Stefan Monnier
2014-02-03  3:48               ` Stefan Monnier [this message]
2014-02-04  5:37             ` Dmitry Gutov
2014-02-04 17:54               ` Stefan Monnier
2014-02-05  4:41                 ` Dmitry Gutov
2014-02-05 13:53                   ` Stefan Monnier
2014-02-06  1:38                     ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvioswsvto.fsf-monnier+emacsbugs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=16604@debbugs.gnu.org \
    --cc=dgutov@yandex.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.