From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#17000: setup ido keymaps only once Date: Wed, 12 Mar 2014 19:36:06 -0400 Message-ID: References: <877g7zfbwr.fsf@bernoul.li> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1394667433 11368 80.91.229.3 (12 Mar 2014 23:37:13 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 12 Mar 2014 23:37:13 +0000 (UTC) Cc: 17000@debbugs.gnu.org To: Jonas Bernoulli Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Mar 13 00:37:21 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WNsi8-0001xs-Cj for geb-bug-gnu-emacs@m.gmane.org; Thu, 13 Mar 2014 00:37:20 +0100 Original-Received: from localhost ([::1]:35544 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNsi7-0007ag-Gv for geb-bug-gnu-emacs@m.gmane.org; Wed, 12 Mar 2014 19:37:19 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35220) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNshx-0007aL-O0 for bug-gnu-emacs@gnu.org; Wed, 12 Mar 2014 19:37:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WNshq-0005sQ-E8 for bug-gnu-emacs@gnu.org; Wed, 12 Mar 2014 19:37:09 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:33873) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNshq-0005sM-An for bug-gnu-emacs@gnu.org; Wed, 12 Mar 2014 19:37:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WNshq-0001D3-2i for bug-gnu-emacs@gnu.org; Wed, 12 Mar 2014 19:37:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Mar 2014 23:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17000 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 17000-submit@debbugs.gnu.org id=B17000.13946673694570 (code B ref 17000); Wed, 12 Mar 2014 23:37:02 +0000 Original-Received: (at 17000) by debbugs.gnu.org; 12 Mar 2014 23:36:09 +0000 Original-Received: from localhost ([127.0.0.1]:35055 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WNsgz-0001Bb-AO for submit@debbugs.gnu.org; Wed, 12 Mar 2014 19:36:09 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:26308) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WNsgx-0001BR-2D for 17000@debbugs.gnu.org; Wed, 12 Mar 2014 19:36:07 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EABK/CFFMCppy/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLNBIUGA0kiB4GwS2RCgOkeoFegxM X-IPAS-Result: Av4EABK/CFFMCppy/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLNBIUGA0kiB4GwS2RCgOkeoFegxM X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="51546108" Original-Received: from 76-10-154-114.dsl.teksavvy.com (HELO ceviche.home) ([76.10.154.114]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 12 Mar 2014 19:36:06 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 6354766090; Wed, 12 Mar 2014 19:36:06 -0400 (EDT) In-Reply-To: <877g7zfbwr.fsf@bernoul.li> (Jonas Bernoulli's message of "Wed, 12 Mar 2014 20:35:16 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:86802 Archived-At: > Currently the ido keymaps are hard to modify because they are recreated > every time `ido-completing-read' is used. Indeed, this is wrong. > I believe it is safe for the "base" ido keymaps to set the value when > the variable is defined, instead of delaying this until ido is actually > used, and then redoing that work whenever `ido-completing-read' is > called. Agreed. > -(defvar ido-common-completion-map nil > +(defvar ido-common-completion-map > + (let ((map (make-sparse-keymap))) [...] > + (set-keymap-parent map minibuffer-local-map) > + (setq ido-common-completion-map map)) This last line should just be "map)". Same for the other maps. Looks good. Please apply after the trunk re-opens. Stefan "Beware: I don't use IDO and don't know its code"