From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#18545: 24.4.50: Bug - forward-line inside with-selected-window Date: Fri, 26 Sep 2014 10:13:45 -0400 Message-ID: References: <1532440199.73121411675536923.JavaMail.www@wwinf7125> <83wq8qu9bt.fsf@gnu.org> <83k34qtsqh.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1411740877 4425 80.91.229.3 (26 Sep 2014 14:14:37 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 26 Sep 2014 14:14:37 +0000 (UTC) Cc: lompik@voila.fr, 18545@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Sep 26 16:14:27 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XXWHy-0006Tv-Er for geb-bug-gnu-emacs@m.gmane.org; Fri, 26 Sep 2014 16:14:26 +0200 Original-Received: from localhost ([::1]:49328 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XXWHx-0003Cp-Uu for geb-bug-gnu-emacs@m.gmane.org; Fri, 26 Sep 2014 10:14:25 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40402) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XXWHn-0003Ao-GQ for bug-gnu-emacs@gnu.org; Fri, 26 Sep 2014 10:14:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XXWHf-0003Rn-FD for bug-gnu-emacs@gnu.org; Fri, 26 Sep 2014 10:14:15 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:33417) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XXWHf-0003R8-BU for bug-gnu-emacs@gnu.org; Fri, 26 Sep 2014 10:14:07 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XXWHZ-0008Pn-NT for bug-gnu-emacs@gnu.org; Fri, 26 Sep 2014 10:14:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 26 Sep 2014 14:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18545 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18545-submit@debbugs.gnu.org id=B18545.141174082932319 (code B ref 18545); Fri, 26 Sep 2014 14:14:01 +0000 Original-Received: (at 18545) by debbugs.gnu.org; 26 Sep 2014 14:13:49 +0000 Original-Received: from localhost ([127.0.0.1]:53214 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XXWHN-0008PD-2C for submit@debbugs.gnu.org; Fri, 26 Sep 2014 10:13:49 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:64468) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XXWHK-0008P4-JL for 18545@debbugs.gnu.org; Fri, 26 Sep 2014 10:13:47 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArYGAIDvNVNFxKjo/2dsb2JhbABZgwaDSr0vgw6BFxd0giUBAQEBAgFWIwULCzQSFBgNJIgECNIZF456B4Q4BKkZgWqDTCE X-IPAS-Result: ArYGAIDvNVNFxKjo/2dsb2JhbABZgwaDSr0vgw6BFxd0giUBAQEBAgFWIwULCzQSFBgNJIgECNIZF456B4Q4BKkZgWqDTCE X-IronPort-AV: E=Sophos;i="4.97,753,1389762000"; d="scan'208";a="90947389" Original-Received: from 69-196-168-232.dsl.teksavvy.com (HELO pastel.home) ([69.196.168.232]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 26 Sep 2014 10:13:45 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 7DA47653D; Fri, 26 Sep 2014 10:13:45 -0400 (EDT) In-Reply-To: <83k34qtsqh.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 26 Sep 2014 16:29:42 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:93771 Archived-At: >> Why does >> (with-selected-window (get-buffer-window "*Completions*") >> (recenter 5)) >> require an explicit call to wset_redisplay from recenter, whereas >> (with-selected-window (get-buffer-window "*Completions*") >> (forward-line 1)) >> doesn't need an explicit call to wset_redisplay (or bset_redisplay) from >> forward-line? > I think that's because forward-line moves point, while recenter > doesn't. But I don't see why moving point would help: calling wset_redisplay should only change the fact that this window is considered for redisplay, so if it's needed for the recenter case, that means that without it, the window would not be considered at all, which in turn should imply that in the forward-line case we wouldn't notice that point has changed, unless set_point_both ends up calling bset_redisplay somehow (but I fail to see how). > But if you'd like to add wset_redisplay to forward-line, I won't > object. If it's not needed, I'd rather not add it. Stefan