* 2 messages to emacs-diffs per each commit?
@ 2014-11-15 18:57 Eli Zaretskii
2014-11-15 19:51 ` Glenn Morris
2014-11-16 3:57 ` Stefan Monnier
0 siblings, 2 replies; 25+ messages in thread
From: Eli Zaretskii @ 2014-11-15 18:57 UTC (permalink / raw)
To: emacs-devel
It looks like every commit causes two messages sent to emacs-diffs.
One says something like "branch emacs-24 updated (d4fceca ->
1fb97e7)", the other is the actual diffs for the commit.
Why is that? If this is redundant, can we fix it?
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: 2 messages to emacs-diffs per each commit?
2014-11-15 18:57 2 messages to emacs-diffs per each commit? Eli Zaretskii
@ 2014-11-15 19:51 ` Glenn Morris
2014-11-15 20:02 ` Eli Zaretskii
2014-11-16 3:57 ` Stefan Monnier
1 sibling, 1 reply; 25+ messages in thread
From: Glenn Morris @ 2014-11-15 19:51 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: emacs-devel
I would much prefer to only get one mail in such cases.
Also, the Mail-Followup-To header is wrong. It should be emacs-devel,
not emacs-diffs. (Ideally, it would also include committer, as it used to
do with bzr.)
I'd also like to lose some of the boilerplate text.
IMO we (emacs-devel) need to decide what changes we would like to see to
these mails, then ask Savannah what is possible; so we don't keep
pestering them with repeated requests.
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: 2 messages to emacs-diffs per each commit?
2014-11-15 18:57 2 messages to emacs-diffs per each commit? Eli Zaretskii
2014-11-15 19:51 ` Glenn Morris
@ 2014-11-16 3:57 ` Stefan Monnier
2014-11-16 15:19 ` Eli Zaretskii
1 sibling, 1 reply; 25+ messages in thread
From: Stefan Monnier @ 2014-11-16 3:57 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: emacs-devel
> It looks like every commit causes two messages sent to emacs-diffs.
AFAIK it's one email per commit plus one email per push.
Maybe we could drop all the "email per push".
Stefan
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: 2 messages to emacs-diffs per each commit?
2014-11-16 3:57 ` Stefan Monnier
@ 2014-11-16 15:19 ` Eli Zaretskii
2014-11-17 2:04 ` Glenn Morris
0 siblings, 1 reply; 25+ messages in thread
From: Eli Zaretskii @ 2014-11-16 15:19 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: emacs-devel@gnu.org
> Date: Sat, 15 Nov 2014 22:57:01 -0500
>
> > It looks like every commit causes two messages sent to emacs-diffs.
>
> AFAIK it's one email per commit plus one email per push.
> Maybe we could drop all the "email per push".
Yes, please, let's drop the "push" emails.
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: 2 messages to emacs-diffs per each commit?
2014-11-16 15:19 ` Eli Zaretskii
@ 2014-11-17 2:04 ` Glenn Morris
2014-11-17 8:49 ` Stephen Berman
2014-11-17 19:17 ` Glenn Morris
0 siblings, 2 replies; 25+ messages in thread
From: Glenn Morris @ 2014-11-17 2:04 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: Stefan Monnier, emacs-devel
I told myself I wouldn't get involved, but I failed. I changed
the Mail-Followup-To, and set multimailhook.refchangeList = ''.
We'll see what that last setting does to the number of emails.
See README at https://github.com/mhagger/git-multimail
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: 2 messages to emacs-diffs per each commit?
2014-11-17 2:04 ` Glenn Morris
@ 2014-11-17 8:49 ` Stephen Berman
2014-11-17 9:59 ` Andreas Schwab
2014-11-17 16:53 ` Glenn Morris
2014-11-17 19:17 ` Glenn Morris
1 sibling, 2 replies; 25+ messages in thread
From: Stephen Berman @ 2014-11-17 8:49 UTC (permalink / raw)
To: Glenn Morris; +Cc: Eli Zaretskii, Stefan Monnier, emacs-devel
On Sun, 16 Nov 2014 21:04:03 -0500 Glenn Morris <rgm@gnu.org> wrote:
> I told myself I wouldn't get involved, but I failed. I changed
> the Mail-Followup-To, and set multimailhook.refchangeList = ''.
> We'll see what that last setting does to the number of emails.
It shortens the number as desired. However, the Subject of the commit
mails does not give the branch, which the Subject of the push mails did.
Here is what the last nine mails looks like in my current Gnus Summary
buffer, the first five before your change, the last four after it:
. ( 28) Lars Ingebrigtsen │ ▶ [emacs] branch master updated (c94988
. ( 226) Lars Ingebrigtsen │ ├─▸ ...[emacs] 01/02: Implement an `inh
. ( 64) Lars Ingebrigtsen │ ╰─▸ ...[emacs] 02/02: Make the eww buff
. ( 28) Paul Eggert │ ▶ [emacs] branch emacs-24 updated (cf10
. ( 244) Paul Eggert │ ╰─▸ ...[emacs] 01/01: Simplify and fix
. ( 48) Paul Eggert │ [emacs] 01/01: Restore 'Bug#' -> 'debbu
. (1511) Paul Eggert │ [emacs] 01/01: Improve time stamp handl
. ( 319) Paul Eggert │ [emacs] 01/01: Spelling fixes.
. ( 102) Paul Eggert │ [emacs] 01/01: Port new time stamp hand
For the last four it would be nice if they looked like this:
. ( 48) Paul Eggert │ [emacs-24] 01/01: Restore 'Bug#' -> 'de
. (1511) Paul Eggert │ [master] 01/01: Improve time stamp hand
. ( 319) Paul Eggert │ [master] 01/01: Spelling fixes.
. ( 102) Paul Eggert │ [master] 01/01: Port new time stamp han
Another wish list item, unrelated to this particular issue but related
to the presentation of the diff mails, is to have the diffs suitably
MIME'd, like the bzr diffs were, so they get nicely fontified (at least
in Gnus), which makes it easier to quickly see the changes.
Steve Berman
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: 2 messages to emacs-diffs per each commit?
2014-11-17 8:49 ` Stephen Berman
@ 2014-11-17 9:59 ` Andreas Schwab
2014-11-17 16:50 ` Glenn Morris
2014-11-17 16:53 ` Glenn Morris
1 sibling, 1 reply; 25+ messages in thread
From: Andreas Schwab @ 2014-11-17 9:59 UTC (permalink / raw)
To: Stephen Berman; +Cc: Eli Zaretskii, Stefan Monnier, emacs-devel
Stephen Berman <stephen.berman@gmx.net> writes:
> Another wish list item, unrelated to this particular issue but related
> to the presentation of the diff mails, is to have the diffs suitably
> MIME'd, like the bzr diffs were, so they get nicely fontified (at least
> in Gnus), which makes it easier to quickly see the changes.
They also use the wrong encoding for the From: line, see Message-ID:
<E1Xq6vI-00079V-Mc@vcs.savannah.gnu.org> for example.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: 2 messages to emacs-diffs per each commit?
2014-11-17 8:49 ` Stephen Berman
2014-11-17 9:59 ` Andreas Schwab
@ 2014-11-17 16:53 ` Glenn Morris
1 sibling, 0 replies; 25+ messages in thread
From: Glenn Morris @ 2014-11-17 16:53 UTC (permalink / raw)
To: Stephen Berman; +Cc: Eli Zaretskii, Stefan Monnier, emacs-devel
Stephen Berman wrote:
> It shortens the number as desired. However, the Subject of the commit
> mails does not give the branch, which the Subject of the push mails did.
Please test it out with a local repo and see if there is a config or
a patch to do that.
> Another wish list item, unrelated to this particular issue but related
> to the presentation of the diff mails, is to have the diffs suitably
> MIME'd, like the bzr diffs were, so they get nicely fontified (at least
> in Gnus), which makes it easier to quickly see the changes.
Please check for upstream bug reports on this and see if there is a
patch or a setting or a whatever.
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: 2 messages to emacs-diffs per each commit?
2014-11-17 2:04 ` Glenn Morris
2014-11-17 8:49 ` Stephen Berman
@ 2014-11-17 19:17 ` Glenn Morris
2014-11-18 8:02 ` Glenn Morris
1 sibling, 1 reply; 25+ messages in thread
From: Glenn Morris @ 2014-11-17 19:17 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: Stefan Monnier, emacs-devel
Glenn Morris wrote:
> set multimailhook.refchangeList = ''.
As I suspected might happen, this apparently broke threading for pushes
that include > 1 commit. Looks like we need the
"fewer-emails-if-single-commit-pushed" branch from
https://github.com/mhagger/git-multimail/ .
I don't know how finished this is.
If someone wants to test that out and report back, that would be nice.
Ref:
https://github.com/mhagger/git-multimail/issues/32
https://github.com/mhagger/git-multimail/pull/51
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: 2 messages to emacs-diffs per each commit?
2014-11-17 19:17 ` Glenn Morris
@ 2014-11-18 8:02 ` Glenn Morris
2014-11-18 12:11 ` Stephen Berman
2014-11-18 14:56 ` Ted Zlatanov
0 siblings, 2 replies; 25+ messages in thread
From: Glenn Morris @ 2014-11-18 8:02 UTC (permalink / raw)
To: emacs-devel
Glenn Morris wrote:
> "fewer-emails-if-single-commit-pushed" branch from
Seems to work, installed.
Also added branch to the subject.
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: 2 messages to emacs-diffs per each commit?
2014-11-18 8:02 ` Glenn Morris
@ 2014-11-18 12:11 ` Stephen Berman
2014-11-18 17:00 ` Glenn Morris
` (2 more replies)
2014-11-18 14:56 ` Ted Zlatanov
1 sibling, 3 replies; 25+ messages in thread
From: Stephen Berman @ 2014-11-18 12:11 UTC (permalink / raw)
To: Glenn Morris; +Cc: emacs-devel
On Tue, 18 Nov 2014 03:02:45 -0500 Glenn Morris <rgm@gnu.org> wrote:
> Also added branch to the subject.
Thanks. I'll try to follow up on the diff fontification issue when I
have time.
Steve Berman
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: 2 messages to emacs-diffs per each commit?
2014-11-18 12:11 ` Stephen Berman
@ 2014-11-18 17:00 ` Glenn Morris
2014-11-18 18:58 ` Stephen Berman
2014-11-18 17:00 ` Glenn Morris
2014-11-25 22:36 ` Johan Bockgård
2 siblings, 1 reply; 25+ messages in thread
From: Glenn Morris @ 2014-11-18 17:00 UTC (permalink / raw)
To: Stephen Berman; +Cc: emacs-devel
Stephen Berman wrote:
> Thanks. I'll try to follow up on the diff fontification issue when I
> have time.
I filed
https://github.com/mhagger/git-multimail/issues/69
but to me the project shows signs of having stalled (no activity in six
months).
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: 2 messages to emacs-diffs per each commit?
2014-11-18 12:11 ` Stephen Berman
2014-11-18 17:00 ` Glenn Morris
@ 2014-11-18 17:00 ` Glenn Morris
2014-11-18 18:40 ` Stefan Monnier
2014-11-25 22:36 ` Johan Bockgård
2 siblings, 1 reply; 25+ messages in thread
From: Glenn Morris @ 2014-11-18 17:00 UTC (permalink / raw)
To: emacs-devel
BTW, since Lars went ahead and pushed his feature branch, everyone now
gets all the diffs for that too, since there is no way to restrict this
thing to specific branches.
https://github.com/mhagger/git-multimail/pull/15
(stalled for over a year)
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: 2 messages to emacs-diffs per each commit?
2014-11-18 12:11 ` Stephen Berman
2014-11-18 17:00 ` Glenn Morris
2014-11-18 17:00 ` Glenn Morris
@ 2014-11-25 22:36 ` Johan Bockgård
2014-11-26 23:12 ` Stephen Berman
2 siblings, 1 reply; 25+ messages in thread
From: Johan Bockgård @ 2014-11-25 22:36 UTC (permalink / raw)
To: emacs-devel
Stephen Berman <stephen.berman@gmx.net> writes:
> On Tue, 18 Nov 2014 03:02:45 -0500 Glenn Morris <rgm@gnu.org> wrote:
>
>> Also added branch to the subject.
>
> Thanks. I'll try to follow up on the diff fontification issue when I
> have time.
Meanwhile, try this in your .gnus
(require 'mm-uu)
;; Replace the default specification for git-format-patch which
;; doesn't seem so useful.
(setcdr (assq 'git-format-patch mm-uu-type-alist)
`("^diff --git " ""
mm-uu-diff-extract
,(lambda ()
(re-search-forward "^--- " nil t)
(re-search-forward "^[^-+@ ]\\|\\'" nil t)
(forward-line -2))
mm-uu-diff-test))
(mm-uu-configure)
Adjust mm-uu-diff-groups-regexp if needed.
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: 2 messages to emacs-diffs per each commit?
2014-11-25 22:36 ` Johan Bockgård
@ 2014-11-26 23:12 ` Stephen Berman
0 siblings, 0 replies; 25+ messages in thread
From: Stephen Berman @ 2014-11-26 23:12 UTC (permalink / raw)
To: emacs-devel
On Tue, 25 Nov 2014 23:36:23 +0100 Johan Bockgård <bojohan@gnu.org> wrote:
> Stephen Berman <stephen.berman@gmx.net> writes:
>
>> On Tue, 18 Nov 2014 03:02:45 -0500 Glenn Morris <rgm@gnu.org> wrote:
>>
>>> Also added branch to the subject.
>>
>> Thanks. I'll try to follow up on the diff fontification issue when I
>> have time.
>
> Meanwhile, try this in your .gnus
>
> (require 'mm-uu)
> ;; Replace the default specification for git-format-patch which
> ;; doesn't seem so useful.
> (setcdr (assq 'git-format-patch mm-uu-type-alist)
> `("^diff --git " ""
> mm-uu-diff-extract
> ,(lambda ()
> (re-search-forward "^--- " nil t)
> (re-search-forward "^[^-+@ ]\\|\\'" nil t)
> (forward-line -2))
> mm-uu-diff-test))
> (mm-uu-configure)
>
> Adjust mm-uu-diff-groups-regexp if needed.
Very nice, thanks!
Steve Berman
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: 2 messages to emacs-diffs per each commit?
2014-11-18 8:02 ` Glenn Morris
2014-11-18 12:11 ` Stephen Berman
@ 2014-11-18 14:56 ` Ted Zlatanov
1 sibling, 0 replies; 25+ messages in thread
From: Ted Zlatanov @ 2014-11-18 14:56 UTC (permalink / raw)
To: emacs-devel
On Tue, 18 Nov 2014 03:02:45 -0500 Glenn Morris <rgm@gnu.org> wrote:
GM> Glenn Morris wrote:
>> "fewer-emails-if-single-commit-pushed" branch from
GM> Seems to work, installed.
GM> Also added branch to the subject.
Thanks! I was just about to ask for that :)
Ted
^ permalink raw reply [flat|nested] 25+ messages in thread
end of thread, other threads:[~2014-11-26 23:12 UTC | newest]
Thread overview: 25+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-15 18:57 2 messages to emacs-diffs per each commit? Eli Zaretskii
2014-11-15 19:51 ` Glenn Morris
2014-11-15 20:02 ` Eli Zaretskii
2014-11-16 3:57 ` Stefan Monnier
2014-11-16 15:19 ` Eli Zaretskii
2014-11-17 2:04 ` Glenn Morris
2014-11-17 8:49 ` Stephen Berman
2014-11-17 9:59 ` Andreas Schwab
2014-11-17 16:50 ` Glenn Morris
2014-11-17 22:32 ` Andreas Schwab
2014-11-17 22:39 ` Andreas Schwab
2014-11-18 0:02 ` Glenn Morris
2014-11-18 9:12 ` Andreas Schwab
2014-11-18 16:54 ` Glenn Morris
2014-11-17 16:53 ` Glenn Morris
2014-11-17 19:17 ` Glenn Morris
2014-11-18 8:02 ` Glenn Morris
2014-11-18 12:11 ` Stephen Berman
2014-11-18 17:00 ` Glenn Morris
2014-11-18 18:58 ` Stephen Berman
2014-11-18 17:00 ` Glenn Morris
2014-11-18 18:40 ` Stefan Monnier
2014-11-25 22:36 ` Johan Bockgård
2014-11-26 23:12 ` Stephen Berman
2014-11-18 14:56 ` Ted Zlatanov
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.