* Re: [Emacs-diffs] tzz/let-alist-package ab4667d: Add let-alist macro and package.
[not found] ` <E1Xyizi-0004zh-Nh@vcs.savannah.gnu.org>
@ 2014-12-10 15:47 ` Stefan Monnier
2014-12-10 16:05 ` Ted Zlatanov
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Monnier @ 2014-12-10 15:47 UTC (permalink / raw)
To: emacs-devel; +Cc: Artur Malabarba
> +;;; News:
> +;;; Code:
There's no need to have a ";;; News:" section, so if it's empty, better
just remove it.
> +(provide 'let-alist)
> +;;; let-alist.el ends here
> +
> +
> +;; Local Variables:
> +;; sentence-end-double-space: t
> +;; End:
Either it ends there or it doesn't. IOW, please move the file local
variables earlier.
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Emacs-diffs] tzz/let-alist-package ab4667d: Add let-alist macro and package.
2014-12-10 15:47 ` [Emacs-diffs] tzz/let-alist-package ab4667d: Add let-alist macro and package Stefan Monnier
@ 2014-12-10 16:05 ` Ted Zlatanov
2014-12-10 19:49 ` Stefan Monnier
0 siblings, 1 reply; 3+ messages in thread
From: Ted Zlatanov @ 2014-12-10 16:05 UTC (permalink / raw)
To: emacs-devel
On Wed, 10 Dec 2014 10:47:36 -0500 Stefan Monnier <monnier@iro.umontreal.ca> wrote:
>> +;;; News:
>> +;;; Code:
SM> There's no need to have a ";;; News:" section, so if it's empty, better
SM> just remove it.
>> +(provide 'let-alist)
>> +;;; let-alist.el ends here
>> +
>> +
>> +;; Local Variables:
>> +;; sentence-end-double-space: t
>> +;; End:
SM> Either it ends there or it doesn't. IOW, please move the file local
SM> variables earlier.
OK. Both changes made in branch tzz/let-alist-package-rc2
It would be nice if user "tzz" was allowed to "git push -f" into
branches that start with "tzz". That's probably hard to implement
though, so I hope you don't mind the new branches. IMO it's better to
amend a commit than make a followup for a trivial fix.
Ted
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Emacs-diffs] tzz/let-alist-package ab4667d: Add let-alist macro and package.
2014-12-10 16:05 ` Ted Zlatanov
@ 2014-12-10 19:49 ` Stefan Monnier
0 siblings, 0 replies; 3+ messages in thread
From: Stefan Monnier @ 2014-12-10 19:49 UTC (permalink / raw)
To: emacs-devel
> though, so I hope you don't mind the new branches. IMO it's better to
> amend a commit than make a followup for a trivial fix.
When reading the commit-diffs, I prefer seeing the incremental change
than seeing a whole new file on another branch (or on the same branch),
so I actually prefer committing a new change on top of the other than
amending a previous commit from that point of view.
For branches with small changes and/or short lifetime, the end result
can be committed without keeping its history (i.e. combining all the
patches into a single one), if you want a cleaner history.
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-12-10 19:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20141210151602.19104.15603@vcs.savannah.gnu.org>
[not found] ` <E1Xyizi-0004zh-Nh@vcs.savannah.gnu.org>
2014-12-10 15:47 ` [Emacs-diffs] tzz/let-alist-package ab4667d: Add let-alist macro and package Stefan Monnier
2014-12-10 16:05 ` Ted Zlatanov
2014-12-10 19:49 ` Stefan Monnier
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.