From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master f7572b7: Fix Semantic completion-at-point functions in non-Semantic buffers Date: Sun, 14 Dec 2014 09:30:14 -0500 Message-ID: References: <20141214105944.8359.64300@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1418567485 10259 80.91.229.3 (14 Dec 2014 14:31:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 14 Dec 2014 14:31:25 +0000 (UTC) Cc: Dmitry Gutov To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Dec 14 15:31:18 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Y0ACa-0003fT-2o for ged-emacs-devel@m.gmane.org; Sun, 14 Dec 2014 15:31:16 +0100 Original-Received: from localhost ([::1]:36165 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0ACZ-0001B7-Hf for ged-emacs-devel@m.gmane.org; Sun, 14 Dec 2014 09:31:15 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44616) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0ACF-0001Ax-JL for emacs-devel@gnu.org; Sun, 14 Dec 2014 09:31:03 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y0AC7-0004Qf-QZ for emacs-devel@gnu.org; Sun, 14 Dec 2014 09:30:55 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:11672) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0AC7-0004Qa-MZ for emacs-devel@gnu.org; Sun, 14 Dec 2014 09:30:47 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AskIAOwQflTO+ILA/2dsb2JhbABbgweDYMp3BAICgSQXAQEBAQEBfIQDAQEEViMQCzQHCxQYDYh31lkBAQEBBgEBAQEekG8HFoQyBYsBpC6BeII3gWIhgncBAQE X-IPAS-Result: AskIAOwQflTO+ILA/2dsb2JhbABbgweDYMp3BAICgSQXAQEBAQEBfIQDAQEEViMQCzQHCxQYDYh31lkBAQEBBgEBAQEekG8HFoQyBYsBpC6BeII3gWIhgncBAQE X-IronPort-AV: E=Sophos;i="5.07,502,1413259200"; d="scan'208";a="101350371" Original-Received: from 206-248-130-192.dsl.teksavvy.com (HELO pastel.home) ([206.248.130.192]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 14 Dec 2014 09:30:44 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 15D76175E; Sun, 14 Dec 2014 09:30:14 -0500 (EST) In-Reply-To: (Dmitry Gutov's message of "Sun, 14 Dec 2014 10:59:45 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:180082 Archived-At: > * lisp/cedet/semantic.el (semantic-analyze-completion-at-point-function) > (semantic-analyze-notc-completion-at-point-function) > (semantic-analyze-nolongprefix-completion-at-point-function): Do > nothing if the current buffer is not using Semantic. Looks like the wrong fix. Don't you think the right fix would be to change the add/remove-hooks in semantic-mode so that they are buffer-local? Stefan